chore: enable --pedantic-solving for all tests with nargo#11224
Merged
Conversation
Contributor
Author
|
This is currently running into the same issue as in the Noir sync in |
Collaborator
|
Hm this could be an issue with doing stuff in parallel in the noir build, you can try |
Member
|
@michaeljklein can you update this to account #11261? |
michaeljklein
force-pushed
the
michaeljklein/nargo-pedantic-solving
branch
from
a00f35a to
d2d3e87
Compare
Contributor
Author
|
@TomAFrench r.e. #11224 (comment): done |
5 tasks
Member
|
This is looking pretty stale now with some pre CI3 stuff which needs to be removed. |
Contributor
Author
|
@TomAFrench just the dockerfile and earthfile? I'm not sure what else could be stale |
Member
|
Yeah, those needed removing. I've marked this as ready for review to see how it does in CI. |
TomAFrench
reviewed
Apr 29, 2025
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
approved these changes
Apr 29, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 1, 2025
…tests` (#13964) 1. Disable `--pedantic-solving` in `acir_tests` for now because the Noir execution tests are already run with `--pedantic-solving` elsewhere 2. The failing tests (`regression_5045`, `regression_7744`) should have been caught in CI in #11224. This appears to be due to the cache key missing `acir_tests/scripts/run_test.sh`, so I've added it
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
May 2, 2025
…tests` (#13964) 1. Disable `--pedantic-solving` in `acir_tests` for now because the Noir execution tests are already run with `--pedantic-solving` elsewhere 2. The failing tests (`regression_5045`, `regression_7744`) should have been caught in CI in AztecProtocol/aztec-packages#11224. This appears to be due to the cache key missing `acir_tests/scripts/run_test.sh`, so I've added it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of this PR in Noir which enables
--pedantic-solvingin all tests that usenargo, including some I missed innoir.