feat: enable creation U128 from string#11584
Closed
Groxan wants to merge 2 commits into
Closed
Conversation
Groxan
changed the title
U128 from stringU128 from string
Member
Contributor
|
@Maddiaa0 looks good to me. Since CI is still broken for external contributors I've opened a replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a safer type check in the
U128constructor and also resolves #11583.Note: it would be more correct to also extend the ctor arg type with
| string, but I skipped it, to avoid API changes.Let me know, if you want this to be done as well.