chore: rc-2 update & beacon node fix for sepolia#11631
Merged
Merged
Conversation
spypsy
changed the title
spypsy
changed the title
PhilWindle
approved these changes
Jan 30, 2025
PhilWindle
approved these changes
Jan 31, 2025
Maddiaa0
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were making requests to the execution layer RPC for beacon node. However this isn't just a config fix because we can't request to
beacon.<api_url>?key=<api_key>/eth/v1/beacon/headers/<hash>askeyquery needs to be attached at the end.Furthermore, GCP seems to not like
keyquery to be added to an API's URL that expects other queries, e.g.beacon.<api_url>/eth/v1/beacon/blob_sidecars/<hash>?indices=1,2,3&key=<api_key>throws error: "BAD_REQUEST: unknown fieldkey, expectedindices"So we need to attach the key as a header, therefore adding another env var
Also added this: #11648 as we clearly should be testing stuff like this against sepolia regularly