chore: prover node has no claims or bonds#11811
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
just-mitch
changed the title
LHerskind
force-pushed
the
lh/multiproof-ep-1
branch
from
ac25317 to
ebf51a8
Compare
just-mitch
force-pushed
the
02-07-prover_node_has_no_claims_or_bonds
branch
from
b41185c to
5fbcb67
Compare
LHerskind
force-pushed
the
lh/multiproof-ep-1
branch
2 times, most recently
from
2b203e0 to
eb4ba26
Compare
just-mitch
force-pushed
the
02-07-prover_node_has_no_claims_or_bonds
branch
from
5fbcb67 to
a2bd753
Compare
just-mitch
force-pushed
the
02-07-prover_node_has_no_claims_or_bonds
branch
2 times, most recently
from
213be4f to
e2f51cf
Compare
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
Looks good, think there might be a one-off in the tests which seems to match what I see in the runs.
|
|
||
| it('getPrivateEvents', async () => { | ||
| const result = await context.client.getPrivateEvents<EpochProofQuote>( | ||
| const result = await context.client.getPrivateEvents<{ value: bigint }>( |
There was a problem hiding this comment.
Not clear to me why this was in here to begin with? Why would the PXE ask for stuff here 🤷
| logger.info('Advancing past the proof claim window'); | ||
| await cheatCodes.rollup.advanceToNextEpoch(); | ||
| await cheatCodes.rollup.advanceSlots(aztecEpochProofClaimWindowInL2Slots + 1); // off-by-one? | ||
| await cheatCodes.rollup.advanceSlots(aztecProofSubmissionWindow + 1); // off-by-one? |
There was a problem hiding this comment.
Should we update the comment here
| const provenBn = await rollup.read.getProvenBlockNumber(); | ||
| const balanceAfterCoinbase = await feeJuice.read.balanceOf([COINBASE_ADDRESS.toString()]); | ||
| const balanceAfterProver = await feeJuice.read.balanceOf([t.proverAddress.toString()]); | ||
| expect(provenBn + 1n).toBe(await rollup.read.getPendingBlockNumber()); |
There was a problem hiding this comment.
Why would we have a +1 in there? If we have just waited until all have been proven, the pending block number should be the same as the proven?
There was a problem hiding this comment.
Think it is a leftover or something that relied on the quotes only being passed along with a proposal, so an extra block was added.
There was a problem hiding this comment.
There is still a ci job for running this test 👀 we should also get rid of that one.
| const partialQuote = await this.quoteProvider.getQuote(Number(epochNumber), blocks); | ||
| if (!partialQuote) { | ||
| this.log.info(`No quote produced for epoch ${epochNumber}`); | ||
| this.log.debug('jobs', JSON.stringify(this.jobs, null, 2)); |
There was a problem hiding this comment.
Should we keep this one?
There was a problem hiding this comment.
I think it's okay- it's at debug level, only once per epoch, and is pretty informative.
LHerskind
force-pushed
the
02-07-prover_node_has_no_claims_or_bonds
branch
from
e2f51cf to
7e17c08
Compare
LHerskind
force-pushed
the
lh/multiproof-ep-1
branch
from
eb4ba26 to
1b40fb6
Compare
just-mitch
force-pushed
the
lh/multiproof-ep-1
branch
from
1b40fb6 to
6eb2612
Compare
just-mitch
force-pushed
the
02-07-prover_node_has_no_claims_or_bonds
branch
from
a25050d to
33fd80c
Compare
Please read [contributing guidelines](CONTRIBUTING.md) and remove this line. --------- Co-authored-by: LHerskind <16536249+LHerskind@users.noreply.github.com>
2 participants
Please read contributing guidelines and remove this line.