fix: uniswap_trade_on_l1_from_l2.test.ts#12389
Merged
Merged
Conversation
benesjan
force-pushed
the
02-28-fix_uniswap_trade_on_l1_from_l2.test.ts
branch
from
d5fcb8e to
6f74cf5
Compare
benesjan
commented
Feb 28, 2025
|
|
||
| const { publicClient, walletClient } = createL1Clients(this.aztecNodeConfig.l1RpcUrls, MNEMONIC); | ||
|
|
||
| const underlyingERC20Address = await deployL1Contract( |
Contributor
Author
There was a problem hiding this comment.
Having this be in the CrossChainTestHarness and having the underlyingERC20Address passed to the CrossChainTestHarness.new function just sometimes made it all hard to debug and quite ugly so I decided to just move it here.
benesjan
commented
Feb 28, 2025
| }); | ||
|
|
||
| // allow anyone to mint | ||
| await underlyingERC20.write.setFreeForAll([true], {} as any); |
Contributor
Author
There was a problem hiding this comment.
This just didn't work at all in cases where underlyingERC20Address was provided on the input because that was typically WETH or DAI address from forked mainnet and those contracts simply did not have setFreeForAll method. This change sneaked into master because the uniswap_trade_on_l1_from_l2.test.ts was never run in the PR that introduced the change.
benesjan
changed the title
uniswap_trade_on_l1_from_l2.test.ts
sklppy88
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12286