Skip to content

fix!: aggregate data for batch calls#12562

Merged
LeilaWang merged 3 commits into
masterfrom
lw/batch_call_fixes
Mar 10, 2025
Merged

fix!: aggregate data for batch calls#12562
LeilaWang merged 3 commits into
masterfrom
lw/batch_call_fixes

Conversation

@LeilaWang

@LeilaWang LeilaWang commented Mar 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • BatchCall now takes an array of BaseContractInteraction, which has all the information including functionCall, authwit and capsules. Before it took an array of functionCall and users would have to set other data to it seperately.
  • BaseContractInteraction has a method request that returns <Omit<ExecutionRequestInit, 'fee'>>. This is called by BatchCall to gather all the data, and used for simulation to estimate fee.

@LeilaWang LeilaWang requested a review from Thunkar March 7, 2025 10:14
@LeilaWang LeilaWang linked an issue Mar 7, 2025 that may be closed by this pull request
bug: can't call public function on contract deployed earlier in block #12453
Closed
Thunkar
Thunkar reviewed Mar 7, 2025
View reviewed changes

@Thunkar Thunkar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeilaWang LeilaWang requested a review from dbanks12 March 7, 2025 12:53
dbanks12
dbanks12 approved these changes Mar 10, 2025
View reviewed changes

@dbanks12 dbanks12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm probably not the best to review the contract interaction stuff, but hopefully @Thunkar followed all of that. Is this a breaking change for dapps that use the sandbox, or only for our e2e tests? If breaking, let's flag as such!

Comment thread yarn-project/end-to-end/src/e2e_deploy_contract/deploy_method.test.ts
Comment on lines -151 to +150
const deploy = await deployMethod.request();
const deployTx = new BatchCall(wallet, deploy.calls);
logger.debug('Getting an instance of the not-yet-deployed contract to batch calls to');
const contract = await StatefulTestContract.at((await deployMethod.getInstance()).address, wallet);
const deployTx = new BatchCall(wallet, [deployMethod]);
logger.debug('Registering the not-yet-deployed contract to batch calls to');
const contract = await deployMethod.register();

@dbanks12 dbanks12 Mar 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! One note is that it feels like we're overloading the term register to mean "register a contract class" and "register a contract instance with the PXE".

@LeilaWang LeilaWang Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's a breaking change. I added it to the migration note. Will flag it in the title. Thanks for pointing this out!

Good point re the term register! When I was changing the code around this, a lot of things were not clear to me. They definitely can use more attention!

@LeilaWang LeilaWang changed the title fix: aggregate data for batch calls fix!: aggregate data for batch calls Mar 10, 2025
@LeilaWang LeilaWang merged commit bd0b3b6 into master Mar 10, 2025
@LeilaWang LeilaWang deleted the lw/batch_call_fixes branch March 10, 2025 14:03
@AztecBot AztecBot mentioned this pull request Mar 10, 2025
Merged
sklppy88 pushed a commit that referenced this pull request Mar 11, 2025
@AztecBot
chore(master): release 0.79.0 (#12578)
cb5d35f 
🤖 I have created a new Aztec Packages release
---


##
[0.79.0](v0.78.1...v0.79.0)
(2025-03-11)


### ⚠ BREAKING CHANGES

* aggregate data for batch calls
([#12562](#12562))

### Features

* add extra attributes to target_info
([#12583](#12583))
([c296422](c296422))
* add optional oracle resolver url in `acvm_cli`
(noir-lang/noir#7630)
([cc6cdbb](cc6cdbb))
* allow to pay via sponsored fpc from cli
([#12598](#12598))
([877de5c](877de5c))
* array concat method (noir-lang/noir#7199)
([cc6cdbb](cc6cdbb))
* **avm:** ToRadix gadget
([#12528](#12528))
([02a7171](02a7171))
* aztec-up -v flag
([#12590](#12590))
([6a41565](6a41565))
* **bb:** consider polynomial end_index when constructing partially
evaluated multivariates
([#12530](#12530))
([abd22cd](abd22cd))
* **config:** add fallbacks
([#12593](#12593))
([f2f9ef3](f2f9ef3))
* **p2p:** add trusted peers mechanics
([#12447](#12447))
([d67f7e8](d67f7e8))
* **p2p:** peer manager peer count metrics
([#12575](#12575))
([b4891c1](b4891c1))
* provision alerts
([#12561](#12561))
([2ea1767](2ea1767))
* Resolve callstacks in protocol circuit errors on wasm
([#12573](#12573))
([657299b](657299b))


### Bug Fixes

* aggregate data for batch calls
([#12562](#12562))
([bd0b3b6](bd0b3b6))
* broken kind transfer test
([#12611](#12611))
([6e91934](6e91934))
* Cl/release fixes 2
([#12595](#12595))
([fc597f4](fc597f4))
* Cl/release noir refs
([#12597](#12597))
([fdcfcaf](fdcfcaf))
* demote log
([#12626](#12626))
([bec8953](bec8953))
* deploy method test
([#12609](#12609))
([f2c06c2](f2c06c2))
* Do not report epoch as complete until blocks have synced
([#12638](#12638))
([2ddfa76](2ddfa76)),
closes
[#12625](#12625)
* Error on infinitely recursive types
(noir-lang/noir#7579)
([cc6cdbb](cc6cdbb))
* get L1 tx utils config from env
([#12620](#12620))
([d930c01](d930c01))
* Log overflow handling in reset
([#12579](#12579))
([283b624](283b624))
* metrics update
([#12571](#12571))
([80a5df2](80a5df2))
* **sandbox:** query release please manifest for version if in a docker
container
([#12591](#12591))
([db8ebc6](db8ebc6))
* **spartan:** setup needs kubectl
([#12580](#12580))
([753cb33](753cb33))
* update dead partial notes link
([#12629](#12629))
([5a1dc4c](5a1dc4c))
* update error message to display 128 bits as valid bit size
(noir-lang/noir#7626)
([cc6cdbb](cc6cdbb))
* update fallback transport
([#12470](#12470))
([88f0711](88f0711))


### Miscellaneous

* bump external pinned commits
(noir-lang/noir#7640)
([cc6cdbb](cc6cdbb))
* **ci3:** add helper for uncached test introspection
([#12618](#12618))
([9ac518b](9ac518b))
* **ci3:** better memsuspend_limit comment
([#12622](#12622))
([de84187](de84187))
* clean up upgrade test and other small things
([#12558](#12558))
([c28abe1](c28abe1))
* cleanup eth artifacts + misc aztec.js reorg
([#12563](#12563))
([6623244](6623244))
* **docs:** Updated accounts page
([#12019](#12019))
([d45dac9](d45dac9))
* Fix mac build
([#12610](#12610))
([adceed6](adceed6))
* gemini soundness regression test
([#12570](#12570))
([c654106](c654106))
* more sane e2e_prover/full timeout
([#12619](#12619))
([add9d35](add9d35))
* reactivate acir_test for `regression_5045`
([#12548](#12548))
([c89f89c](c89f89c))
* remove unnecessary trait bounds
(noir-lang/noir#7635)
([cc6cdbb](cc6cdbb))
* Rename `StructDefinition` to `TypeDefinition`
(noir-lang/noir#7614)
([cc6cdbb](cc6cdbb))
* replace relative paths to noir-protocol-circuits
([4f7f5c3](4f7f5c3))
* replace relative paths to noir-protocol-circuits
([0f68d11](0f68d11))
* replace relative paths to noir-protocol-circuits
([8f593ce](8f593ce))
* replace relative paths to noir-protocol-circuits
([251ae38](251ae38))
* rollup library cleanup
([#12621](#12621))
([361fc59](361fc59))
* **sandbox:** drop cheat-codes log level
([#12586](#12586))
([24f04c7](24f04c7))
* **sandbox:** expose anvil port
([#12599](#12599))
([955f1b0](955f1b0))
* **testnet:** updating script for ignition, change naming
([#12566](#12566))
([2d7b69d](2d7b69d))
* turn on masking in eccvm
([#12467](#12467))
([aacb91a](aacb91a))
* Update Bb line counting script
([#12350](#12350))
([7a41843](7a41843))
* update docs to reflect u128 type
(noir-lang/noir#7623)
([cc6cdbb](cc6cdbb))
* Validate blobs posted to sink belong to our L2
([#12587](#12587))
([9578f1e](9578f1e)),
closes
[#12497](#12497)


### Documentation

* update cli-wallet commands in profiler doc
([#12568](#12568))
([239a4fb](239a4fb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thunkar Thunkar Thunkar left review comments

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: can't call public function on contract deployed earlier in block

3 participants

@LeilaWang @Thunkar @dbanks12