Skip to content

feat: use public processor for txe private calls part 1#12779

Closed
sklppy88 wants to merge 1 commit into
masterfrom
ek/feat/use-public-processor-for-txs-p1
Closed

feat: use public processor for txe private calls part 1#12779
sklppy88 wants to merge 1 commit into
masterfrom
ek/feat/use-public-processor-for-txs-p1

Conversation

@sklppy88

@sklppy88 sklppy88 commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

This PR is currently in draft and looking for feedback, but shows how we can use the public processor to handle state and put the TXe even closer to a real execution model. This is a purely additive change, and implements a new endpoint on the test_environment as well as a cheatcode to make a private call with this new method.

Currently when we enqueue a public function call, we execute it right away. Also, we do not run the teardown function as the final call. Also, we are forced to manually add side-effects to trees and build a block. (This is currently extremely brittle with how public side-effects are handled). With this change we will correctly run functions in order, also we are letting the processor handle all the side effect management, which cuts down on the complexity by a lot and further lets us explore using a real node to process TXe transactions.

There is one remaining outstanding issue:

  • More robust note hash and nullifier management will have to be implemented, which will include cases of private function calling an external private function which emits side effects.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sklppy88 sklppy88 changed the title init feat: use public processor for txe private calls part 1 Mar 17, 2025
@sklppy88 sklppy88 force-pushed the ek/feat/use-public-processor-for-txs-p1 branch 5 times, most recently from a5ec8b5 to c21dbc1 Compare March 17, 2025 07:09
@sklppy88 sklppy88 requested a review from Thunkar March 17, 2025 07:18
@sklppy88 sklppy88 force-pushed the ek/feat/use-public-processor-for-txs-p1 branch from c21dbc1 to e9b5643 Compare March 25, 2025 00:57
@sklppy88

sklppy88 commented May 9, 2025

Copy link
Copy Markdown
Contributor Author

Superceded by #14020

@sklppy88 sklppy88 closed this May 9, 2025
@sklppy88 sklppy88 deleted the ek/feat/use-public-processor-for-txs-p1 branch May 9, 2025 14:20
@sklppy88 sklppy88 restored the ek/feat/use-public-processor-for-txs-p1 branch May 9, 2025 14:20
@sklppy88 sklppy88 deleted the ek/feat/use-public-processor-for-txs-p1 branch May 14, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant