feat: use public processor for txe private calls part 1#12779
Closed
sklppy88 wants to merge 1 commit into
Closed
Conversation
a5ec8b5 to
c21dbc1
Compare
c21dbc1 to
e9b5643
Compare
Contributor
Author
|
Superceded by #14020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is currently in draft and looking for feedback, but shows how we can use the public processor to handle state and put the TXe even closer to a real execution model. This is a purely additive change, and implements a new endpoint on the
test_environmentas well as a cheatcode to make a private call with this new method.Currently when we enqueue a public function call, we execute it right away. Also, we do not run the teardown function as the final call. Also, we are forced to manually add side-effects to trees and build a block. (This is currently extremely brittle with how public side-effects are handled). With this change we will correctly run functions in order, also we are letting the processor handle all the side effect management, which cuts down on the complexity by a lot and further lets us explore using a real node to process TXe transactions.
There is one remaining outstanding issue: