feat(avm): instruction fetching parsing error#12804
Merged
Merged
Conversation
jeanmon
force-pushed
the
jm/instr-fetch-parsing-error
branch
from
8e290fa to
0a2d781
Compare
jeanmon
commented
Mar 17, 2025
| SumcheckRoundUnivariate compute_univariate(ProverPolynomialsOrPartiallyEvaluatedMultivariates& polynomials, | ||
| const bb::RelationParameters<FF>& relation_parameters, | ||
| const bb::GateSeparatorPolynomial<FF>& gate_sparators, | ||
| const bb::GateSeparatorPolynomial<FF>& gate_separators, |
Contributor
Author
There was a problem hiding this comment.
Corrected a typo as part of this PR in sumcheck_round.hpp. Not relevant for the review.
jeanmon
commented
Mar 17, 2025
| namespace bb::avm2 { | ||
|
|
||
| template <typename T> | ||
| requires(std::unsigned_integral<T>) |
Contributor
Author
There was a problem hiding this comment.
Was ported from vm1
jeanmon
force-pushed
the
jm/instr-fetch-parsing-error
branch
from
0a2d781 to
43f24fa
Compare
jeanmon
requested review from
IlyasRidhuan,
Maddiaa0 and
fcarreiro
as code owners
jeanmon
force-pushed
the
jm/instr-fetch-parsing-error
branch
from
81962c8 to
98f2f73
Compare
❌ Deploy Preview for barretenberg failed. Why did it fail? →
|
fcarreiro
reviewed
Mar 18, 2025
fcarreiro
left a comment
fcarreiro
left a comment
Contributor
There was a problem hiding this comment.
Will review C++ but left some PIL comments already.
fcarreiro
reviewed
Mar 18, 2025
jeanmon
force-pushed
the
jm/instr-fetch-parsing-error
branch
3 times, most recently
from
ebb9686 to
fab4e8e
Compare
jeanmon
commented
Mar 19, 2025
|
|
||
| /** | ||
| * @brief Scale Univaraites, each representing a subrelation, by different challenges | ||
| * @brief Scale Univariates, each representing a subrelation, by different challenges |
Contributor
Author
There was a problem hiding this comment.
Just a corrected typo as part of this PR.
jeanmon
commented
Mar 19, 2025
fcarreiro
reviewed
Mar 19, 2025
fcarreiro
reviewed
Mar 19, 2025
fcarreiro
reviewed
Mar 19, 2025
fcarreiro
left a comment
fcarreiro
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but will let Ilyas check the PIL and approve. Thanks for all the changes!
added 19 commits
March 20, 2025 08:01
InstructionWithError structure in deserialization
jeanmon
force-pushed
the
jm/instr-fetch-parsing-error
branch
from
4553dda to
ea7b570
Compare
IlyasRidhuan
approved these changes
Mar 20, 2025
IlyasRidhuan
left a comment
IlyasRidhuan
left a comment
Contributor
There was a problem hiding this comment.
Good stuff! Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.