Skip to content

fix: pull CRS data ahead of time#12945

Merged
alexghr merged 1 commit into
masterfrom
ag/download-crs-ahead-of-time
Mar 21, 2025
Merged

fix: pull CRS data ahead of time#12945
alexghr merged 1 commit into
masterfrom
ag/download-crs-ahead-of-time

Conversation

@alexghr

@alexghr alexghr commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Download a bunch of points needed for proof generation/verification.
NOTE: the point files are cached so if the files that exist in the default location already contain enough points this is a noop (a good idea to use docker volumes)

@alexghr alexghr force-pushed the ag/download-crs-ahead-of-time branch from f0e0844 to 7cdec43 Compare March 21, 2025 17:55
alexghr
alexghr commented Mar 21, 2025
View reviewed changes
Comment thread yarn-project/aztec/src/cli/util.ts
): Promise<void> {
if (realProofs) {
const { Crs, GrumpkinCrs } = await import('@aztec/bb.js');
await Promise.all([Crs.new(2 ** 1, undefined, log), GrumpkinCrs.new(2 ** 16 + 1, undefined, log)]);

@alexghr alexghr Mar 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values taken from master-rc-1

@alexghr alexghr force-pushed the ag/download-crs-ahead-of-time branch from 7cdec43 to 2478949 Compare March 21, 2025 18:20
@alexghr alexghr force-pushed the ag/download-crs-ahead-of-time branch from 2478949 to 97c77b1 Compare March 21, 2025 18:24
@alexghr alexghr enabled auto-merge (squash) March 21, 2025 18:24
charlielye
charlielye reviewed Mar 21, 2025
View reviewed changes
Comment thread yarn-project/aztec/src/cli/util.ts
): Promise<void> {
if (realProofs) {
const { Crs, GrumpkinCrs } = await import('@aztec/bb.js');
await Promise.all([Crs.new(2 ** 25 - 1, undefined, log), GrumpkinCrs.new(2 ** 18 + 1, undefined, log)]);

@charlielye charlielye Mar 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit concerned here, think node might blow up beyond 2gb file sizes - this may literally be against the limit, but if you've tested it works... (also this will gobble 2gb mem and possibly hold onto it?, its not neatly streaming it into the file). I guess if you dont hold a ref to the CRS garbage collection should reap it...

@alexghr alexghr Mar 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the GC to reap it and yeah it did work on mainframe, but streaming it would make sense haha. I'll log a ticket for next week
Logged an issue here #12948

@alexghr alexghr mentioned this pull request Mar 21, 2025
Closed
@alexghr alexghr disabled auto-merge March 21, 2025 18:46
@alexghr alexghr enabled auto-merge (squash) March 21, 2025 18:49
@alexghr alexghr merged commit 43155d6 into master Mar 21, 2025
@alexghr alexghr deleted the ag/download-crs-ahead-of-time branch March 21, 2025 18:50
@AztecBot AztecBot mentioned this pull request Mar 21, 2025
Merged
PhilWindle pushed a commit that referenced this pull request Mar 24, 2025
@AztecBot
chore(master): release 0.82.1 (#12943)
5b80383 
🤖 I have created a new Aztec Packages release
---


##
[0.82.1](v0.82.0...v0.82.1)
(2025-03-24)


### Features

* **avm:** Port field gt to vm2
([#12883](#12883))
([0ae6891](0ae6891))
* use msgpack for ClientIvc::Proof in API
([#12911](#12911))
([1a01602](1a01602))


### Bug Fixes

* disable proving on vite box
([#12971](#12971))
([69a0fb6](69a0fb6))
* no hardcoded versions in bbup
([#12944](#12944))
([397144f](397144f))
* pull CRS data ahead of time
([#12945](#12945))
([43155d6](43155d6))
* Remove workaround
([#12952](#12952))
([c3337af](c3337af))
* set the correct env var
([#12959](#12959))
([bd0f4b2](bd0f4b2))
* yolo add bunch of test flakes
([13c19da](13c19da))
* yolo e2e_p2p tests now fully skipped due to huge speed regression
([9141410](9141410))
* yolo txe binds just to localhost by default.
([3933b35](3933b35))


### Miscellaneous

* Change `/bin/bash` shebang to be env based
([#12834](#12834))
([7843a67](7843a67))
* clean up avm codeowners
([#12860](#12860))
([35a8f46](35a8f46))
* deflake the kind smoke test
([#12955](#12955))
([1a37d6d](1a37d6d)),
closes
[#11177](#11177)
* fee cleanup
([#12941](#12941))
([fdf1da4](fdf1da4))
* Increase bot count
([#12963](#12963))
([16edd06](16edd06))
* L2 chain config for alpha testnet
([#12962](#12962))
([e13edb8](e13edb8))
* Reduce bots
([#12953](#12953))
([4bbc5da](4bbc5da))
* remove selector from public call request
([#12828](#12828))
([18bcc1b](18bcc1b))
* replace relative paths to noir-protocol-circuits
([61cf4b6](61cf4b6))
* replace relative paths to noir-protocol-circuits
([4356c17](4356c17))
* replace relative paths to noir-protocol-circuits
([f73f47d](f73f47d))
* Set default proving config to true
([#12964](#12964))
([75c1549](75c1549))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
DanielKotov pushed a commit that referenced this pull request Mar 27, 2025
@alexghr @DanielKotov
fix: pull CRS data ahead of time (#12945)
421c371 
Download a bunch of points needed for proof generation/verification.
NOTE: the point files are cached so if the files that exist in the
default location already contain enough points this is a noop (a good
idea to use docker volumes)
DanielKotov pushed a commit that referenced this pull request Mar 27, 2025
@AztecBot @DanielKotov
chore(master): release 0.82.1 (#12943)
2726712 
🤖 I have created a new Aztec Packages release
---


##
[0.82.1](v0.82.0...v0.82.1)
(2025-03-24)


### Features

* **avm:** Port field gt to vm2
([#12883](#12883))
([0ae6891](0ae6891))
* use msgpack for ClientIvc::Proof in API
([#12911](#12911))
([1a01602](1a01602))


### Bug Fixes

* disable proving on vite box
([#12971](#12971))
([69a0fb6](69a0fb6))
* no hardcoded versions in bbup
([#12944](#12944))
([397144f](397144f))
* pull CRS data ahead of time
([#12945](#12945))
([43155d6](43155d6))
* Remove workaround
([#12952](#12952))
([c3337af](c3337af))
* set the correct env var
([#12959](#12959))
([bd0f4b2](bd0f4b2))
* yolo add bunch of test flakes
([13c19da](13c19da))
* yolo e2e_p2p tests now fully skipped due to huge speed regression
([9141410](9141410))
* yolo txe binds just to localhost by default.
([3933b35](3933b35))


### Miscellaneous

* Change `/bin/bash` shebang to be env based
([#12834](#12834))
([7843a67](7843a67))
* clean up avm codeowners
([#12860](#12860))
([35a8f46](35a8f46))
* deflake the kind smoke test
([#12955](#12955))
([1a37d6d](1a37d6d)),
closes
[#11177](#11177)
* fee cleanup
([#12941](#12941))
([fdf1da4](fdf1da4))
* Increase bot count
([#12963](#12963))
([16edd06](16edd06))
* L2 chain config for alpha testnet
([#12962](#12962))
([e13edb8](e13edb8))
* Reduce bots
([#12953](#12953))
([4bbc5da](4bbc5da))
* remove selector from public call request
([#12828](#12828))
([18bcc1b](18bcc1b))
* replace relative paths to noir-protocol-circuits
([61cf4b6](61cf4b6))
* replace relative paths to noir-protocol-circuits
([4356c17](4356c17))
* replace relative paths to noir-protocol-circuits
([f73f47d](f73f47d))
* Set default proving config to true
([#12964](#12964))
([75c1549](75c1549))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
DanielKotov pushed a commit that referenced this pull request Mar 27, 2025
@alexghr @DanielKotov
fix: pull CRS data ahead of time (#12945)
d3e2dd7 
Download a bunch of points needed for proof generation/verification.
NOTE: the point files are cached so if the files that exist in the
default location already contain enough points this is a noop (a good
idea to use docker volumes)
DanielKotov pushed a commit that referenced this pull request Mar 27, 2025
@AztecBot @DanielKotov
chore(master): release 0.82.1 (#12943)
a1954d9 
🤖 I have created a new Aztec Packages release
---


##
[0.82.1](v0.82.0...v0.82.1)
(2025-03-24)


### Features

* **avm:** Port field gt to vm2
([#12883](#12883))
([0ae6891](0ae6891))
* use msgpack for ClientIvc::Proof in API
([#12911](#12911))
([1a01602](1a01602))


### Bug Fixes

* disable proving on vite box
([#12971](#12971))
([69a0fb6](69a0fb6))
* no hardcoded versions in bbup
([#12944](#12944))
([397144f](397144f))
* pull CRS data ahead of time
([#12945](#12945))
([43155d6](43155d6))
* Remove workaround
([#12952](#12952))
([c3337af](c3337af))
* set the correct env var
([#12959](#12959))
([bd0f4b2](bd0f4b2))
* yolo add bunch of test flakes
([13c19da](13c19da))
* yolo e2e_p2p tests now fully skipped due to huge speed regression
([9141410](9141410))
* yolo txe binds just to localhost by default.
([3933b35](3933b35))


### Miscellaneous

* Change `/bin/bash` shebang to be env based
([#12834](#12834))
([7843a67](7843a67))
* clean up avm codeowners
([#12860](#12860))
([35a8f46](35a8f46))
* deflake the kind smoke test
([#12955](#12955))
([1a37d6d](1a37d6d)),
closes
[#11177](#11177)
* fee cleanup
([#12941](#12941))
([fdf1da4](fdf1da4))
* Increase bot count
([#12963](#12963))
([16edd06](16edd06))
* L2 chain config for alpha testnet
([#12962](#12962))
([e13edb8](e13edb8))
* Reduce bots
([#12953](#12953))
([4bbc5da](4bbc5da))
* remove selector from public call request
([#12828](#12828))
([18bcc1b](18bcc1b))
* replace relative paths to noir-protocol-circuits
([61cf4b6](61cf4b6))
* replace relative paths to noir-protocol-circuits
([4356c17](4356c17))
* replace relative paths to noir-protocol-circuits
([f73f47d](f73f47d))
* Set default proving config to true
([#12964](#12964))
([75c1549](75c1549))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlielye charlielye charlielye left review comments

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexghr @charlielye @PhilWindle