Skip to content

refactor!: UnsconstrainedContext --> UtilityContext#13246

Merged
benesjan merged 4 commits into
masterfrom
04-02-refactorunsconstrainedcontext_--_utilitycontext
Apr 4, 2025
Merged

refactor!: UnsconstrainedContext --> UtilityContext#13246
benesjan merged 4 commits into
masterfrom
04-02-refactorunsconstrainedcontext_--_utilitycontext

Conversation

@benesjan

@benesjan benesjan commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Partially addresses #12743 (partially as the rest will be addressed in PRs up the stacks)

In this PR I only rename UnconstrainedContext as UtilityContext. The rest of the unconstrained --> utility renaming will be done in PRs up the stack.

@benesjan Graphite App

benesjan commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan mentioned this pull request Apr 2, 2025
Merged
@benesjan benesjan changed the title refactorUnsconstrainedContext --> UtilityContext refactor!: UnsconstrainedContext --> UtilityContext Apr 2, 2025
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from f252453 to c08fa9b Compare April 2, 2025 20:05
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 9e5bd02 to 38d59b2 Compare April 2, 2025 20:05
This was referenced Apr 2, 2025
Closed
Merged
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from c08fa9b to b2841a7 Compare April 2, 2025 22:06
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 38d59b2 to 0d312a9 Compare April 2, 2025 22:06
@benesjan benesjan mentioned this pull request Apr 2, 2025
Merged
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 0d312a9 to 5fdc5fc Compare April 2, 2025 23:53
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from b2841a7 to 99b6219 Compare April 2, 2025 23:53
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 5fdc5fc to 61a1885 Compare April 2, 2025 23:54
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from 99b6219 to de330ef Compare April 2, 2025 23:54
@benesjan benesjan marked this pull request as ready for review April 3, 2025 02:35
@benesjan benesjan requested a review from sklppy88 April 3, 2025 02:35
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from de330ef to d7fe962 Compare April 3, 2025 02:47
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from d7fe962 to bb11b60 Compare April 3, 2025 15:34
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 19530b9 to 986418b Compare April 3, 2025 15:34
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from bb11b60 to 8cdc38c Compare April 3, 2025 18:30
nventuro
nventuro approved these changes Apr 3, 2025
View reviewed changes
Comment thread docs/docs/migration_notes.md
```

With this change the `UnconstrainedContext` has been renamed as `UtilityContext`.
This led us to rename the `unkonstrained` method on `TestEnvironment` as `utility` so you will need to update your tests using that:

@nventuro nventuro Apr 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's on the cspell too

@benesjan benesjan Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly it's not there
image

@benesjan benesjan mentioned this pull request Apr 3, 2025
Merged
@benesjan benesjan marked this pull request as draft April 3, 2025 20:19
@benesjan benesjan changed the base branch from 04-02-feat_utility_function to graphite-base/13246 April 3, 2025 20:20
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from 8cdc38c to bf04498 Compare April 3, 2025 20:29
@benesjan benesjan force-pushed the graphite-base/13246 branch from cfe32dc to 569919f Compare April 3, 2025 20:29
@benesjan benesjan changed the base branch from graphite-base/13246 to 04-02-feat_utility_function April 3, 2025 20:29
@benesjan benesjan marked this pull request as ready for review April 3, 2025 22:15
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 569919f to c1c0e74 Compare April 3, 2025 22:50
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from bf04498 to 876c7e0 Compare April 3, 2025 22:50
Base automatically changed from 04-02-feat_utility_function to master April 3, 2025 23:43
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from 876c7e0 to 4b2c2f6 Compare April 4, 2025 01:08
@benesjan Graphite App

benesjan commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Apr 3, 9:38 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 3, 9:38 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).
  • Apr 3, 9:39 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 3, 9:40 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).

@benesjan benesjan added this pull request to the merge queue Apr 4, 2025
Merged via the queue into master with commit 69df86f Apr 4, 2025
@benesjan benesjan deleted the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch April 4, 2025 02:04
@AztecBot AztecBot mentioned this pull request Apr 4, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Apr 4, 2025
@AztecBot
chore(master): release 0.84.0 (#13267)
9165027 
🤖 I have created a new Aztec Packages release
---


##
[0.84.0](v0.83.1...v0.84.0)
(2025-04-04)


### ⚠ BREAKING CHANGES

* `UnsconstrainedContext` --> `UtilityContext`
([#13246](#13246))
* `#[utility]` function
([#13243](#13243))
* Validate public setup fns and gas in p2p
([#13154](#13154))

### Features

* `#[utility]` function
([#13243](#13243))
([945ffa2](945ffa2))
* **avm:** tx hint init
([#13218](#13218))
([60a1a92](60a1a92))
* Remove 4 byte metadata from bb-produced proof
([#13231](#13231))
([0dcc915](0dcc915))
* To enable better ci dashboard.
([#13272](#13272))
([61c6375](61c6375))


### Bug Fixes

* **avm:** fix lookup builder and FF hashing
([#13263](#13263))
([2633856](2633856))
* ci3-external concurrency bug, reduce grind set
([2c5e830](2c5e830)),
closes
[#13285](#13285)
* ci3-external.yml
([#13291](#13291))
([6ad68ed](6ad68ed))
* Validate public setup fns and gas in p2p
([#13154](#13154))
([1ef4add](1ef4add)),
closes
[#10958](#10958)


### Miscellaneous

* `UnsconstrainedContext` --> `UtilityContext`
([#13246](#13246))
([69df86f](69df86f))
* add some PrivateSet tests
([#13270](#13270))
([bd9e690](bd9e690))
* bump full prover test to 32 cores. hoping to boost speed.
([#13293](#13293))
([c8e95dd](c8e95dd))
* deflake p2p reqresp test
([#13271](#13271))
([b9164fa](b9164fa))
* don't dump on fail. click the link instead.
([#13292](#13292))
([ba0fb4d](ba0fb4d))
* flake
([#13277](#13277))
([62c32eb](62c32eb))
* make rahul happy with migration notes
([#13255](#13255))
([3dd75a6](3dd75a6))
* minor simulator utils cleanup
([#13250](#13250))
([8a622c9](8a622c9))
* move a couple of `SharedMutableValues` functions outside of impl
([#13283](#13283))
([df9a40c](df9a40c))
* nuking debug-only logger and various unused functionality in
`foundation`
([#13187](#13187))
([2d38e60](2d38e60))
* prevent eth devnet config contention in ci
([#13260](#13260))
([1581836](1581836))
* renaming unconstrained function as utility in TS
([#13249](#13249))
([34d03bb](34d03bb))
* replace relative paths to noir-protocol-circuits
([b5b99f8](b5b99f8))
* Speed up note hashes test
([#13282](#13282))
([ad23358](ad23358))
* update gov and proposer configs
([#13281](#13281))
([e1a5be3](e1a5be3))
* update slashing test port
([#13274](#13274))
([9a1ddc5](9a1ddc5))
* Want to fail fast on test runs and the wider ci run.
([#13258](#13258))
([f0553b8](f0553b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nventuro nventuro nventuro approved these changes

+1 more reviewer

@sklppy88 sklppy88 sklppy88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benesjan @nventuro @sklppy88