fix: Restart archiver loop if L1 block falls more than 128 blocks behind#13602
Merged
Conversation
spypsy
approved these changes
Apr 17, 2025
Contributor
Author
|
@LHerskind given your comments on Slack, I'll wait for your ok before merging. |
LHerskind
approved these changes
Apr 29, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
spalladino
force-pushed
the
palla/check-old-block-tag
branch
from
d4bb45d to
e04ae54
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
spalladino
force-pushed
the
palla/check-old-block-tag
branch
from
e04ae54 to
57be3f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
currentL1Blockused in the archiver sync loop falls more than 128 blocks behind (eg during a very long sync), theneth_calloperations that pin the block number (status,canPrune) may end up querying a block evicted by a non-archive node. If this happens, we just abort the current sync and restart. This should not evict any messages or blocks already downloaded.Fixes #13596