fix: fix visibility issues#13685
Merged
Merged
Conversation
LeilaWang
approved these changes
Apr 22, 2025
charlielye
approved these changes
Apr 22, 2025
charlielye
left a comment
charlielye
left a comment
Contributor
There was a problem hiding this comment.
Approving file i own.
commit 49bf7af Merge: 3278e92 36fb0a1 Author: TomAFrench <tom@tomfren.ch> Date: Tue Apr 22 13:58:28 2025 +0000 Merge branch 'master' into tf/fix-visibility-issues commit 3278e92 Merge: 360c814 593f810 Author: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Tue Apr 22 12:00:26 2025 +0100 Merge branch 'master' into tf/fix-visibility-issues commit 360c814 Author: TomAFrench <tom@tomfren.ch> Date: Tue Apr 22 10:06:43 2025 +0000 chore: check libraries in parallel commit 4f22ed1 Author: TomAFrench <tom@tomfren.ch> Date: Tue Apr 22 09:57:04 2025 +0000 chore: fix warnings commit 9ad5221 Author: TomAFrench <tom@tomfren.ch> Date: Tue Apr 22 09:49:04 2025 +0000 . commit a24aa22 Author: TomAFrench <tom@tomfren.ch> Date: Fri Apr 18 20:14:28 2025 +0000 . commit 3578a6b Author: TomAFrench <tom@tomfren.ch> Date: Fri Apr 18 20:02:00 2025 +0000 . commit 6b4d5f2 Author: TomAFrench <tom@tomfren.ch> Date: Fri Apr 18 19:29:45 2025 +0000 . commit 3467149 Author: TomAFrench <tom@tomfren.ch> Date: Fri Apr 18 19:29:17 2025 +0000 . commit 74579ca Author: TomAFrench <tom@tomfren.ch> Date: Fri Apr 18 18:09:12 2025 +0000 . commit e5bd8b5 Merge: c223fb2 8e2a3c9 Author: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Fri Apr 18 17:21:42 2025 +0100 Merge branch 'master' into tf/fix-visibility-issues commit c223fb2 Author: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Fri Apr 18 17:21:19 2025 +0100 Update Nargo.toml commit 56fb513 Author: TomAFrench <tom@tomfren.ch> Date: Fri Apr 18 16:18:41 2025 +0000 fix: fix visibility issues
TomAFrench
force-pushed
the
tf/fix-visibility-issues
branch
from
49bf7af to
ce4deda
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Pulls out some changes from #13685
TomAFrench
commented
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes various visibility issues in the codebase. I've added some extra checks in bootstrap to prevent warnings from slipping into the protocol circuit libraries.
@MirandaWood This PR also updates the version of the bignum library which we're using which will have knock-on effects on your blobs work.