chore: read-only classes for GovernanceContract & L1TxUtils#13762
Merged
Conversation
spalladino
approved these changes
Apr 23, 2025
Comment on lines
33
to
35
| export function isExtendedClient(client: ViemClient): client is ExtendedViemWalletClient { | ||
| return 'account' in client; | ||
| return 'account' in client && client.account !== undefined; | ||
| } |
Contributor
There was a problem hiding this comment.
Is this method still in use after the refactor?
Member
Author
There was a problem hiding this comment.
yes, to strong type-check in L1TxUtils constructor and a couple more places (that could also be split into readOnly possibly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13715