fix(p2p): better batch connection sampling (#13674)#13763
Merged
PhilWindle merged 1 commit intoApr 23, 2025
Conversation
## Overview Improves batch connection sampling such that we can increase the retry attempts for prover nodes requesting transaction information from their peers. ### Core improvements **Previously** When making a batch request, we requested the peer list, iterated through it until we found a peer without an reqresp active connection and used those. This meant that we were commonly only using the first 3-4 peers in the peer list. Now it will do random sampling without replacement to peers without already active reqresp connections. If there are non available, then we will just sample from peers already servicing requests.
spalladino
approved these changes
Apr 23, 2025
PhilWindle
approved these changes
Apr 23, 2025
PhilWindle
deleted the
md/apply-better-batch-connection-to-alpha-testnet
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply #13674 to alpha-testnet