Skip to content

fix: bringing back global variable builder interface in aztec node#13874

Merged
sklppy88 merged 1 commit into
masterfrom
ek/fix/global-variable-builder-correct-interface
Apr 28, 2025
Merged

fix: bringing back global variable builder interface in aztec node#13874
sklppy88 merged 1 commit into
masterfrom
ek/fix/global-variable-builder-correct-interface

Conversation

@sklppy88

@sklppy88 sklppy88 commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

This is required because a downstack PR implements GlobalVariablesBuilder in a different way and thus this makes more sense to have as a minimal interface.

sklppy88 commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sklppy88 sklppy88 force-pushed the ek/fix/global-variable-builder-correct-interface branch from 3892f4e to 4b513b3 Compare April 28, 2025 10:00
@sklppy88 sklppy88 changed the title nit# fix: incorrect global variable builder in aztec node Apr 28, 2025
@sklppy88 sklppy88 marked this pull request as ready for review April 28, 2025 11:43
@sklppy88 sklppy88 changed the title fix: incorrect global variable builder in aztec node fix: incorrect ? global variable builder in aztec node Apr 28, 2025
@sklppy88 sklppy88 changed the title fix: incorrect ? global variable builder in aztec node fix: bringing back global variable builder interface in aztec node Apr 28, 2025
@sklppy88 sklppy88 requested a review from LeilaWang April 28, 2025 12:03

@LeilaWang LeilaWang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@sklppy88 sklppy88 added this pull request to the merge queue Apr 28, 2025
Merged via the queue into master with commit 5573491 Apr 28, 2025
@sklppy88 sklppy88 deleted the ek/fix/global-variable-builder-correct-interface branch April 28, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants