Skip to content

fix: disable '--pedantic-solving' and fix related cache key in acir_tests #13964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
May 1, 2025
Merged

fix: disable '--pedantic-solving' and fix related cache key in acir_tests #13964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
677cf24
fix: disable '--pedantic-solving' in bb acir_tests, add '.rebuild_pat…
michaeljklein Apr 30, 2025
f876345
Merge branch 'master' into michaeljklein/disable-bb-pedantic-solving
michaeljklein Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions barretenberg/acir_tests/.rebuild_patterns
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
^acir_tests/scripts/run_test.sh
2 changes: 2 additions & 0 deletions barretenberg/acir_tests/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ export bb=$(realpath ../cpp/build/bin/bb)
tests_tar=barretenberg-acir-tests-$(hash_str \
$(../../noir/bootstrap.sh hash-tests) \
$(cache_content_hash \
./.rebuild_patterns \
../cpp/.rebuild_patterns \
)).tar.gz

tests_hash=$(hash_str \
$(../../noir/bootstrap.sh hash-tests) \
$(cache_content_hash \
^barretenberg/acir_tests/ \
./.rebuild_patterns \
../cpp/.rebuild_patterns \
../ts/.rebuild_patterns))

Expand Down
2 changes: 1 addition & 1 deletion barretenberg/acir_tests/scripts/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if [ "$COMPILE" -ne 0 ]; then
export RAYON_NUM_THREADS=${RAYON_NUM_THREADS:-4}
rm -rf target
set +e
compile_output=$($nargo compile --pedantic-solving --silence-warnings 2>&1 && $nargo execute --pedantic-solving 2>&1)
compile_output=$($nargo compile --silence-warnings 2>&1 && $nargo execute 2>&1)
result=$?
set -e
if [ "$result" -ne 0 ]; then
Expand Down