fix: Recover from block gaps in archiver#14087
Merged
Merged
Conversation
PhilWindle
approved these changes
May 7, 2025
spalladino
added a commit
that referenced
this pull request
May 7, 2025
spalladino
added a commit
that referenced
this pull request
May 7, 2025
spalladino
added a commit
that referenced
this pull request
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges 3 commits into alpha-testnet:
Test blob sources on archiver startupis a cherry-pick from a commit in chore: Blob and archiver syncing improvements #13542 in master.Throw on gaps in blocks in archivercauses the archiver to throw ongetBlockscalls where there are gaps, instead of just returning the next available block. This was masking the world-state syncing errors: a missing block in the archiver would result on the next block being returned, so world state syncing would skip a block and fail. This commit also changes the aztec-node to usegetBlock(number)from the archiver, instead ofgetBlocks(number, limit:1).Recover from block gaps due to spurious L2 reorgsmakes the archiver check if the previous block exists when adding new ones. If not, it rolls back the L1 syncpoint to the last known block. This should help recover from spurious L2 reorgs where the archiver prunes blocks when it shouldn't have (more info in debug: Troubleshoot state corruption #13604). Note that this piece of code from feat: Support for L1 reorgs #13428 should also help, but we have not yet moved L1 reorg code to alpha-testnet, and this change is less intrusive.Except for the first one, these commits are not yet in master.
Fixes #13604