chore: advance block when deploying contract txe#14107
Merged
sklppy88 merged 1 commit intoMay 8, 2025
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sklppy88
force-pushed
the
ek/chore/advance-block-when-deploying-contract-txe
branch
3 times, most recently
from
ae340e8 to
b37b64b
Compare
sklppy88
force-pushed
the
ek/chore/advance-block-when-deploying-contract-txe
branch
from
b37b64b to
55fc46b
Compare
sklppy88
changed the base branch from
graphite-base/14107
to
ek/fix/13221/counter-contract-tests-reenable-state-committing
sklppy88
force-pushed
the
ek/chore/advance-block-when-deploying-contract-txe
branch
3 times, most recently
from
dffa7b7 to
ab516e8
Compare
Base automatically changed from
ek/fix/13221/counter-contract-tests-reenable-state-committing
to
master
May 7, 2025 11:37
sklppy88
force-pushed
the
ek/chore/advance-block-when-deploying-contract-txe
branch
3 times, most recently
from
f189f51 to
6c71df1
Compare
sklppy88
force-pushed
the
ek/chore/advance-block-when-deploying-contract-txe
branch
from
6c71df1 to
f5173d8
Compare
Thunkar
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we mine an extra block when we do not need to and not after any initializers have been emitted, forcing us to
env.advance_block_by()after any time we deploy to actually discover those side effects via note discovery.Note that this removes the ability to check the note cache directly after deployment but I think that is such a niche case and we can always re-add an endpoint that doesn't advance block after deployment if necessary