Skip to content

feat: add txe test contract + a new helper that disables out of context oracles#14165

Merged
sklppy88 merged 1 commit into
masterfrom
ek/feat/add-new-txe-helper-with-disabled-oracles
May 9, 2025
Merged

feat: add txe test contract + a new helper that disables out of context oracles#14165
sklppy88 merged 1 commit into
masterfrom
ek/feat/add-new-txe-helper-with-disabled-oracles

Conversation

@sklppy88

@sklppy88 sklppy88 commented May 8, 2025

Copy link
Copy Markdown
Contributor

This PR simply moves some tests from in CounterContract #14020 to a new bespoke TXETest contract. Also it puts the scaffolding in for disabling oracles in a txe test not invoked from a env. function

sklppy88 commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sklppy88 sklppy88 changed the title init feat: add txe helper contract May 8, 2025
@sklppy88 sklppy88 changed the title feat: add txe helper contract feat: add txe test contract with new helper that disables out of context oracles May 8, 2025
@sklppy88 sklppy88 marked this pull request as ready for review May 8, 2025 14:29
@sklppy88 sklppy88 force-pushed the ek/feat/add-new-txe-helper-with-disabled-oracles branch 2 times, most recently from 928dc74 to 370b80b Compare May 8, 2025 15:45
@sklppy88 sklppy88 changed the title feat: add txe test contract with new helper that disables out of context oracles feat: add txe test contract + a new helper that disables out of context oracles May 8, 2025
@sklppy88 sklppy88 requested a review from Thunkar May 8, 2025 16:19
@@ -210,26 +212,56 @@ export class TXEService {
// PXE oracles

getRandomField() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is more stable it would be good to create a proxy or something to avoid all of this boilerplate!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree !

@Thunkar Thunkar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@sklppy88 sklppy88 added this pull request to the merge queue May 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 9, 2025
@sklppy88 sklppy88 force-pushed the ek/feat/add-new-txe-helper-with-disabled-oracles branch from 370b80b to 022e094 Compare May 9, 2025 10:54
@sklppy88 sklppy88 requested a review from charlielye as a code owner May 9, 2025 10:54
@sklppy88 sklppy88 enabled auto-merge May 9, 2025 10:54
@sklppy88 sklppy88 added this pull request to the merge queue May 9, 2025
Merged via the queue into master with commit cf08c09 May 9, 2025
8 checks passed
@sklppy88 sklppy88 deleted the ek/feat/add-new-txe-helper-with-disabled-oracles branch May 9, 2025 11:27
@sklppy88 sklppy88 removed the request for review from charlielye May 9, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants