Skip to content

test: fix flakey test#14592

Merged
alexghr merged 1 commit into
nextfrom
ag/fix-flaky-test
May 29, 2025
Merged

test: fix flakey test#14592
alexghr merged 1 commit into
nextfrom
ag/fix-flaky-test

Conversation

@alexghr

@alexghr alexghr commented May 28, 2025

Copy link
Copy Markdown
Contributor

This PR attempts to fix the flakey epochs_empty_blocks test. There were a couple of problems with this test resulting from #13428:

  • the test assumes it will run for N consecutive epochs
  • but the test also waits for certain blocks to become proven/finalised/historical
  • in feat: Support for L1 reorgs #13428 the meaning of 'finalised' was changed. This caused the test to skip entire epochs (e.g. entire epochs would be proven in the background while it waited for historical blocks)
  • this PR replicates the 'finalised' logic from the archiver so that the epoch counter updates correctly

@alexghr alexghr enabled auto-merge May 28, 2025 19:54
@alexghr alexghr added this pull request to the merge queue May 29, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@alexghr alexghr added this pull request to the merge queue May 29, 2025
Merged via the queue into next with commit c511f72 May 29, 2025
4 checks passed
@alexghr alexghr deleted the ag/fix-flaky-test branch May 29, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants