Skip to content

fix: prevent world-state from spamming the logs #14594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 1 commit into from
May 29, 2025
Merged

fix: prevent world-state from spamming the logs #14594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion yarn-project/world-state/src/synchronizer/server_world_state_synchronizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ export class ServerWorldStateSynchronizer
private syncPromise = promiseWithResolvers<void>();
protected blockStream: L2BlockStream | undefined;

// WorldState doesn't track the proven block number, it only tracks the latest tips of the pending chain and the finalised chain
// store the proven block number here, in the synchronizer, so that we don't end up spamming the logs with 'chain-proved' events
private provenBlockNumber: bigint | undefined;

constructor(
private readonly merkleTreeDb: MerkleTreeAdminDatabase,
private readonly l2BlockSource: L2BlockSource & L1ToL2MessageSource,
Expand Down Expand Up @@ -248,7 +252,7 @@ export class ServerWorldStateSynchronizer
return {
latest: latestBlockId,
finalized: { number: Number(status.finalisedBlockNumber), hash: '' },
proven: { number: Number(status.finalisedBlockNumber), hash: '' }, // TODO(palla/reorg): Using finalised as proven for now
proven: { number: Number(this.provenBlockNumber ?? status.finalisedBlockNumber), hash: '' }, // TODO(palla/reorg): Using finalised as proven for now
};
}

Expand Down Expand Up @@ -345,6 +349,7 @@ export class ServerWorldStateSynchronizer
}

private handleChainProven(blockNumber: number) {
this.provenBlockNumber = BigInt(blockNumber);
this.log.debug(`Proven chain is now at block ${blockNumber}`);
return Promise.resolve();
}
Expand All @@ -353,6 +358,7 @@ export class ServerWorldStateSynchronizer
this.log.warn(`Chain pruned to block ${blockNumber}`);
const status = await this.merkleTreeDb.unwindBlocks(BigInt(blockNumber));
this.latestBlockHashQuery = undefined;
this.provenBlockNumber = undefined;
this.instrumentation.updateWorldStateMetrics(status);
}

Expand Down