Skip to content

fix: error on goodbye #14679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 1 commit into from
Jun 2, 2025
Merged

fix: error on goodbye #14679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions yarn-project/p2p/src/services/reqresp/reqresp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,16 +666,19 @@ export class ReqResp {
errorStatus = e.status;
}

const sendErrorChunk = this.sendErrorChunk(errorStatus);

// Return and yield the response chunk
await pipe(
stream,
async function* (_source: any) {
yield* sendErrorChunk;
},
stream,
);
if (stream.status === 'open') {
const sendErrorChunk = this.sendErrorChunk(errorStatus);
// Return and yield the response chunk
await pipe(
stream,
async function* (_source: any) {
yield* sendErrorChunk;
},
stream,
);
} else {
this.logger.debug('Stream already closed, not sending error response', { protocol, err: e, errorStatus });
}
} finally {
//NOTE: All other status codes indicate closed stream.
//Either graceful close (closed/closing) or forced close (aborted/reset)
Expand Down