chore: field_t pow changes#14680
Merged
Merged
Conversation
iakovenkos
commented
Jun 2, 2025
| accumulator *= running_power; | ||
| } | ||
| } | ||
| if (shifted_exponent != 0) { |
Contributor
Author
There was a problem hiding this comment.
no need to check this in a while loop
…ol/aztec-packages into si/pow-for-integer-exponents
iakovenkos
changed the title
pow impl for uint32_t matches the bigfield powpow impl for witness_t matches the bigfield pow
iakovenkos
changed the title
pow impl for witness_t matches the bigfield powpow changes
Rumata888
requested changes
Jun 12, 2025
| } | ||
| // Use the constant version that perfoms only the necessary multiplications if the exponent is constant | ||
| if (exponent.is_constant()) { | ||
| return pow(static_cast<uint32_t>(exponent_value)); |
Contributor
There was a problem hiding this comment.
You're missing an assert that the value is at most 32 bits
Rumata888
approved these changes
Jun 12, 2025
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
Made sure that the current impl of `field_t` `pow()` matches the audited (and [deprecated](AztecProtocol#14563)) implementation of `bigfield` `pow()`. The `pow` method taking const integers as an argument is taken from AztecProtocol#14610
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made sure that the current impl of
field_tpow()matches the audited (and deprecated) implementation ofbigfieldpow().The
powmethod taking const integers as an argument is taken from #14610