feat!: (sequence of) Apps share a transcript until a kernel is encountered#15313
Merged
federicobarbacovi merged 8 commits intoJun 27, 2025
Merged
Conversation
| EXPECT_TRUE(ivc.prove_and_verify()); | ||
| }; | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
Removing as this was a duplicate of Basic
ledwards2225
approved these changes
Jun 26, 2025
ledwards2225
left a comment
ledwards2225
left a comment
Contributor
There was a problem hiding this comment.
LGTM - couple of typos and a suggestion for a small design reconsideration
| { | ||
| circuit.databus_propagation_data.is_kernel = true; | ||
|
|
||
| // Transcript for shared among recursive verification of K_{i-1} (kernel), A_{i,1} (app), .., A_{i, n} (app) |
Contributor
There was a problem hiding this comment.
Suggested change
| // Transcript for shared among recursive verification of K_{i-1} (kernel), A_{i,1} (app), .., A_{i, n} (app) | |
| // Transcript to be shared shared across recursive verification of K_{i-1} (kernel), A_{i,1} (app), .., A_{i, n} (app) |
Contributor
Author
There was a problem hiding this comment.
I made it even more specific
| bus_depot.propagate_return_data_commitments(circuit); | ||
|
|
||
| // Transcript for shared among K_{i} (kernel), A_{i+1,1} (app), .., A_{i+1, n} (app) | ||
| accumulation_transcript = std::make_shared<Transcript>(); |
Contributor
There was a problem hiding this comment.
Ok so I think placing the reset here works but I wonder if its logically the best place for it. An alternative would be doing this in accumulate based on the is_kernel flag in the VK. I think the latter makes the intent slightly clearer - what do you think?
Contributor
Author
There was a problem hiding this comment.
I agree with your suggestion. Note that the is_kernel flag at the moment is buried inside DatabusPropagationData. I opened an issue #1454 to investigate whether that's the correct place for it.
ludamad
force-pushed
the
merge-train/barretenberg
branch
from
d1c4ee7 to
6fd7599
Compare
AztecBot
force-pushed
the
merge-train/barretenberg
branch
from
f2bf14f to
a6a2ca0
Compare
ludamad
force-pushed
the
merge-train/barretenberg
branch
from
a6a2ca0 to
c3d52d3
Compare
AztecBot
force-pushed
the
merge-train/barretenberg
branch
from
6538c96 to
53d2735
Compare
ludamad
force-pushed
the
merge-train/barretenberg
branch
from
53d2735 to
ff7f1aa
Compare
AztecBot
force-pushed
the
merge-train/barretenberg
branch
2 times, most recently
from
c0b053b to
e3d7312
Compare
…b/apps_share_transcript_until_a_kernel
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). chore: update merge-train documentation feat!: (sequence of) Apps share a transcript until a kernel is encountered (#15313) chore: bigfield todo fixes (#15202) chore: remove insecure logic from ipa recursion (#14102) chore: bigfield audit fixes that change circuits (#15205) feat: stdlib::Proof (#15410) fix: build bb for bench_ivc script (#15429) chore: revert "feat: stdlib::Proof (#15410)" (#15431) chore: unrevert stdlib proof (#15443) chore: package vk hash with vk (#15318) chore: fix avm build (#15448) chore: skip building wasm for bench_ivc when NO_WASM=1 (#15462) chore: add a link to audit PR template in default PR template (#15463) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). chore: update merge-train documentation feat!: (sequence of) Apps share a transcript until a kernel is encountered (#15313) chore: bigfield todo fixes (#15202) chore: remove insecure logic from ipa recursion (#14102) chore: bigfield audit fixes that change circuits (#15205) feat: stdlib::Proof (#15410) fix: build bb for bench_ivc script (#15429) chore: revert "feat: stdlib::Proof (#15410)" (#15431) chore: unrevert stdlib proof (#15443) chore: package vk hash with vk (#15318) chore: fix avm build (#15448) chore: skip building wasm for bench_ivc when NO_WASM=1 (#15462) chore: add a link to audit PR template in default PR template (#15463) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com>
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). chore: update merge-train documentation feat!: (sequence of) Apps share a transcript until a kernel is encountered (AztecProtocol#15313) chore: bigfield todo fixes (AztecProtocol#15202) chore: remove insecure logic from ipa recursion (AztecProtocol#14102) chore: bigfield audit fixes that change circuits (AztecProtocol#15205) feat: stdlib::Proof (AztecProtocol#15410) fix: build bb for bench_ivc script (AztecProtocol#15429) chore: revert "feat: stdlib::Proof (AztecProtocol#15410)" (AztecProtocol#15431) chore: unrevert stdlib proof (AztecProtocol#15443) chore: package vk hash with vk (AztecProtocol#15318) chore: fix avm build (AztecProtocol#15448) chore: skip building wasm for bench_ivc when NO_WASM=1 (AztecProtocol#15462) chore: add a link to audit PR template in default PR template (AztecProtocol#15463) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make Apps share a transcript until a kernel is encountered. This is in preparation for the work on consistency checks.