-
Notifications
You must be signed in to change notification settings - Fork 607
feat: stdlib::Proof #15410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stdlib::Proof #15410
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ struct GoblinRecursiveVerifierOutput { | |
| using PairingAccumulator = PairingPoints<Builder>; | ||
| PairingAccumulator points_accumulator; | ||
| OpeningClaim<Curve> opening_claim; | ||
| StdlibProof<Builder> ipa_proof; | ||
| stdlib::Proof<Builder> ipa_proof; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In contrast to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I generally dont define an alias if there is only a single usage unless it significantly improves readability |
||
| }; | ||
|
|
||
| class GoblinRecursiveVerifier { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment: my editor complains that we don't use
nested_ipa_claims.empty()