feat(bb): add subset of bbrpc. test api_client_ivc.cpp#15476
Merged
ludamad merged 21 commits intoJul 3, 2025
Conversation
- Add api_client_ivc.test.cpp with tests for ClientIVC API - Add bbrpc_commands.hpp defining RPC command structures - Add supporting headers (bbrpc_common.hpp, bbrpc_execute.hpp, proving_helpers.hpp) - Add named_union.hpp for command variant handling - Add acir_bincode_mocks.hpp for test data generation - Add compress_and_save method to PrivateExecutionStepRaw - Fix mock circuit construction to avoid public input conflicts These changes carve out the necessary components for ClientIVC API testing without modifying the existing api_client_ivc.cpp implementation.
AztecBot
force-pushed
the
merge-train/barretenberg
branch
from
6e073a5 to
1829e9a
Compare
AztecBot
force-pushed
the
merge-train/barretenberg
branch
from
1829e9a to
83791b3
Compare
…/carve-out-api-client-ivc-tests
Adds versions of all recursive verifiers involved in CIVC recursive verification that take the appropriate stdlib proof type. I've opted not to remove the versions that take a a native proof since they're not inherently insecure (although can be misused). We may decide to remove them in the future.
…c-tests' into ad/bbrpc/carve-out-api-client-ivc-tests
AztecBot
force-pushed
the
ad/bbrpc/carve-out-api-client-ivc-tests
branch
from
4c3af73 to
9a1f1b8
Compare
ludamad
force-pushed
the
ad/bbrpc/carve-out-api-client-ivc-tests
branch
from
9a1f1b8 to
e10b13a
Compare
ludamad
commented
Jul 2, 2025
ludamad
changed the title
ludamad
changed the title
ludamad
commented
Jul 2, 2025
AztecBot
force-pushed
the
merge-train/barretenberg
branch
from
141bfcd to
74bac59
Compare
added 2 commits
July 3, 2025 03:06
…/carve-out-api-client-ivc-tests
…i-client-ivc-tests
ledwards2225
reviewed
Jul 3, 2025
ledwards2225
left a comment
ledwards2225
left a comment
Contributor
There was a problem hiding this comment.
Awesome stuff, just left some general comments and points for discussion. I don't love the manual nature of constructing the ACIR for these tests so I do wonder if there's some way we could make that easier/more robust. E.g. if we wanted to scale it out to handle other kernels it would be pretty finicky I think. Maybe that's just not even necessary though since these are meant to be minimal tests of the interface, not the underlying logic (I assume).
ledwards2225
approved these changes
Jul 3, 2025
ludamad
force-pushed
the
ad/bbrpc/carve-out-api-client-ivc-tests
branch
from
0059459 to
a69771c
Compare
ludamad
force-pushed
the
ad/bbrpc/carve-out-api-client-ivc-tests
branch
from
a69771c to
c1eb3bc
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). feat: script to benchmark example flows remotely (#15469) chore: Distribute content equally for each range (#15403) fix: update default benchmark in benchmark_remote.sh (#15500) feat(bb): add subset of bbrpc. test api_client_ivc.cpp (#15476) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
AztecBot
pushed a commit
that referenced
this pull request
Jul 4, 2025
…etenberg original commits: - 74bac59 [empty] Start merge-train. Choo choo. (74bac59) - 18d5b23 feat: script to benchmark example flows remotely (#15469) (18d5b23) - 3cf54e5 chore: Distribute content equally for each range (#15403) (3cf54e5) - a61ee43 fix: update default benchmark in benchmark_remote.sh (#15500) (a61ee43) - b14dbc4 feat(bb): add subset of bbrpc. test api_client_ivc.cpp (#15476) (b14dbc4) - eb5af58 fix(merge-train): don't enter re-merge loop (eb5af58) - 2983c24 Update auto_rebase_pr.sh (2983c24) - 66f4632 Update auto_rebase_pr.sh (66f4632)
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). feat: script to benchmark example flows remotely (AztecProtocol#15469) chore: Distribute content equally for each range (AztecProtocol#15403) fix: update default benchmark in benchmark_remote.sh (AztecProtocol#15500) feat(bb): add subset of bbrpc. test api_client_ivc.cpp (AztecProtocol#15476) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks out a ready-to-merge chunk of bbrpc functionality.
bbrpc_commands.hpp defining RPC command structures
named_union.hpp for command variant handling
bbrpc_execute.hpp doing some basic execution
added the first acir-serializing tests to api_client_ivc.test.cpp