Skip to content

chore: nuke bit array #15522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iakovenkos merged 2 commits into from
Jul 4, 2025
Merged

chore: nuke bit array #15522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c94c9fe
nuke bit array
iakovenkos Jul 4, 2025
86efce3
fix misleading comments
iakovenkos Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/docs/Fuzzing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_C_COMPILER=<path to clang> -DCMA

## Currently supported

Currently we have fuzzers for bigfield, bit_array, bool, byte_array, field, safe_uint and uint. Each of them is available in 2 versions: StandardPlonk, ALL (differential fuzzing of 2 versions).
Currently we have fuzzers for bigfield, bool, byte_array, field, safe_uint and uint. Each of them is available in 2 versions: StandardPlonk, ALL (differential fuzzing of 2 versions).
To compile all fuzzers just type `make`.

## Running the fuzzer
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include "barretenberg/ecc/groups/precomputed_generators_secp256r1_impl.hpp"
#include "barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp"
#include "barretenberg/stdlib/hash/sha256/sha256.hpp"
#include "barretenberg/stdlib/primitives//bit_array/bit_array.hpp"
#include "barretenberg/stdlib/primitives/curves/secp256k1.hpp"

namespace bb::stdlib {
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s_plookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "blake2s_plookup.hpp"
#include "blake_util.hpp"

#include "barretenberg/stdlib/primitives/bit_array/bit_array.hpp"
#include "barretenberg/stdlib/primitives/field/field.hpp"
#include "barretenberg/stdlib/primitives/plookup/plookup.hpp"
#include "barretenberg/stdlib/primitives/uint/uint.hpp"
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s_plookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "blake3s_plookup.hpp"
#include "../blake2s/blake_util.hpp"

#include "barretenberg/stdlib/primitives/bit_array/bit_array.hpp"
#include "barretenberg/stdlib/primitives/field/field.hpp"
#include "barretenberg/stdlib/primitives/plookup/plookup.hpp"
#include "barretenberg/stdlib/primitives/uint/uint.hpp"
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/hash/keccak/keccak.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <array>

namespace bb::stdlib {
template <typename Builder> class bit_array;

/**
* @brief KECCAAAAAAAAAAK
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// =====================

#include "sha256.hpp"
#include "barretenberg/stdlib/primitives/bit_array/bit_array.hpp"
#include "barretenberg/stdlib/primitives/circuit_builders/circuit_builders.hpp"
#include "sha256_plookup.hpp"

Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/hash/sha256/sha256.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
// namespace bb

namespace bb::stdlib {
template <typename Builder> class bit_array;

template <typename Builder>
std::array<uint32<Builder>, 8> sha256_block(const std::array<uint32<Builder>, 8>& h_init,
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/hash/sha256/sha256_plookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include "sha256_plookup.hpp"

#include "barretenberg/stdlib/primitives/bit_array/bit_array.hpp"
#include "barretenberg/stdlib/primitives/field/field.hpp"
#include "barretenberg/stdlib/primitives/plookup/plookup.hpp"
#include "barretenberg/stdlib/primitives/uint/uint.hpp"
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "../circuit_builders/circuit_builders.hpp"
#include "bigfield.hpp"

#include "../bit_array/bit_array.hpp"
#include "../field/field.hpp"
#include "barretenberg/transcript/origin_tag.hpp"

Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#pragma once

#include "../bit_array/bit_array.hpp"
#include "../circuit_builders/circuit_builders.hpp"
#include "../plookup/plookup.hpp"
#include "barretenberg/ecc/groups/precomputed_generators.hpp"
#include "barretenberg/stdlib/primitives/biggroup/biggroup.hpp"
#include "barretenberg/transcript/origin_tag.hpp"
Expand Down
168 changes: 0 additions & 168 deletions barretenberg/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading