Skip to content

chore: remove individual historic roots from privateCircuitPublicInputs#1571

Merged
Maddiaa0 merged 28 commits into
masterfrom
md/priv_inputs_fix
Aug 18, 2023
Merged

chore: remove individual historic roots from privateCircuitPublicInputs#1571
Maddiaa0 merged 28 commits into
masterfrom
md/priv_inputs_fix

Conversation

@Maddiaa0

@Maddiaa0 Maddiaa0 commented Aug 15, 2023

Copy link
Copy Markdown
Member

Add a bit more consistency across the code base, I came into these issues when working on #1515.

Running this in a separate pr as it is not directly related. And to minimise the diff between the two

Overview

Replaces 6 seperate roots with one single data structure that is used literally everywhere else

@Maddiaa0 Maddiaa0 marked this pull request as draft August 15, 2023 15:23
Base automatically changed from md/p-context to master August 15, 2023 16:29
@Maddiaa0 Maddiaa0 changed the base branch from master to docs/jc/update-branding August 18, 2023 19:50
@Maddiaa0 Maddiaa0 changed the base branch from docs/jc/update-branding to master August 18, 2023 19:50
@Maddiaa0 Maddiaa0 requested review from LHerskind and dbanks12 August 18, 2023 19:51
@Maddiaa0 Maddiaa0 marked this pull request as ready for review August 18, 2023 19:51

@dbanks12 dbanks12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice cleanup

@Maddiaa0 Maddiaa0 changed the title feat: remove individual historic roots from privateCircuitPublicInputs chore: remove individual historic roots from privateCircuitPublicInputs Aug 18, 2023
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) August 18, 2023 19:55
@Maddiaa0 Maddiaa0 merged commit 088cbe5 into master Aug 18, 2023
@Maddiaa0 Maddiaa0 deleted the md/priv_inputs_fix branch August 18, 2023 20:13
codygunton pushed a commit that referenced this pull request Jan 23, 2024
* Initial attempt to have Kebab perform deployments (#1558)

* Initial attempt to have Kebab perform deployments

* Fix e2e tests, don't redeploy if given rollup contract

* Use correct verification key

* Bug fix

* VK fix

* Added curl to Falafel docker image

* WIP

* WIP

* Updated Faucet

* WIP

* Deploy mainnet fork alongside kebab (#1556)

* Deploy mainnet fork alongside kebab

* Added backend block

* Updated kebab TF

Co-authored-by: PhilWindle <philip.windle@gmail.com>

* WIP

* Fixed env var name

* WIP

* Yarn lock files

* Revert explorer and zk-money changes

* Use devnet specific private key

* Additional logging

* Attempt to fix block explorer

* Reverted unnecessary change

* Fix bigint literals and remove hosted sdk e2e test

* Fixes

Co-authored-by: spypsy <spypsy@users.noreply.github.com>

* Fixed command ordering (#1566)

* Fixed scripting (#1567)

* More TF fixes (#1571)

* Force contract redeploy (dev) (#1568)

* force contract redeploy + add port to kebab health check

* undo port specification for healthcheck

* Log the number of drips provided by the faucet (#1518)

* Pw/devnet deployment fixes (#1574)

* Terraform changes to restart Falafel and Faucet on redeployment

* New Devnet chain id

* Fix pkey srs size to (n + 1) while loading a pkey. (#1550)

* Pw/devnet deployment fixes (#1577)

* Terraform changes to restart Falafel and Faucet on redeployment

* New Devnet chain id

* Fixed Falafel Dev Terraform

* Fixed Faucet Dev Terraform (#1578)

* Updated Wasabi Terraform for Dev and Test nets (#1579)

* Fix for Wasabi Uniswap Terraform (#1580)

* update JSON provider request method (#1588)

* update JSON provider request method

* comment clarification

* allow additional methods to go through kebab auth (#1589)

* Allow for setting of Rollup Provider in deployments (#1590)

* Allow for setting of Rollup Provider in deployments

* Force contract redeployment

* Terraform fix

* Pw/testnet deployment (#1591)

* WIP

* WIP

* WIP

* TF updates

* Dev TF fix

Co-authored-by: spypsy <spypsy@users.noreply.github.com>
Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants