chore: Always push blobs to sink#15866
Merged
Merged
Conversation
spalladino
force-pushed
the
palla/always-push-to-blob-sink
branch
from
6ceb153 to
1f7dc96
Compare
spalladino
force-pushed
the
palla/always-push-to-blob-sink
branch
from
1f7dc96 to
143f9a9
Compare
PhilWindle
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've hit the
Unable to get blob sidecarflake again even after the fix (see the issue description for a detailed overview of what the underlying problem is). The issue seems to be coming from the Anvil test watcher this time, since it's updating the wall time at the same time the tx is perceived as failed.So, this time I'm addressing the symptom instead of the cause. This PR changes the sequencer publisher so it always publishes blob data to the sink, instead of waiting for its success.
However, the blob sink required the block in which the tx was mined in order to accept the blob, as it indexed blobs by block. So this PR also changes the blob sink to just index blobs by hash and not block.
However, the blob sink server required the block in order to fall back to consensus to fetch the blobs on a miss (see first item in #13542). That feature had been introduced so the blob sink could serve blobs in situations where not all nodes pushed to the sink, such as testnet, but that setup has been deprecated as confirmed by @alexghr. So this PR also removes the blob sink server fallback on a miss.