feat!: avm bugfix of erroneous tag error in tracegen on div by 0#16388
Merged
Conversation
This was referenced Aug 14, 2025
Contributor
Author
This was referenced Aug 14, 2025
dbanks12
force-pushed
the
db/fix-div-by-0
branch
from
f4f7f01 to
85c1a9f
Compare
dbanks12
force-pushed
the
db/misc-fixes
branch
from
2f8e3ec to
ba329d4
Compare
dbanks12
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
MirandaWood
approved these changes
Aug 15, 2025
MirandaWood
left a comment
MirandaWood
left a comment
Contributor
There was a problem hiding this comment.
Good catch! I thought I covered this one in tests, but I realise now my div_0_error test also emits a tag error, so I will add a test case myself at some point. Thank you!
✅ Deploy Preview for barretenberg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Please read [contributing guidelines](CONTRIBUTING.md) and remove this line. For audit-related pull requests, please use the [audit PR template](?expand=1&template=audit.md).
AztecBot
force-pushed
the
db/fix-div-by-0
branch
from
ce7a51a to
c173ee4
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.
For audit-related pull requests, please use the audit PR template.