Skip to content

fix some wasm-related tests + async / await#172

Merged
spypsy merged 4 commits into
masterfrom
sp/wasm-test-fixes
Apr 4, 2023
Merged

fix some wasm-related tests + async / await#172
spypsy merged 4 commits into
masterfrom
sp/wasm-test-fixes

Conversation

@spypsy

@spypsy spypsy commented Apr 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • getDummyPreviousKernelData needs pedersen__init
  • don't use randomBytes in snapshot testing

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spypsy spypsy mentioned this pull request Apr 4, 2023
Merged
@spypsy spypsy merged commit 9f13f08 into master Apr 4, 2023
@spypsy spypsy deleted the sp/wasm-test-fixes branch April 4, 2023 14:55
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@phated @kevaundray
feat: Add equality and serialization to poly_triple (#172)
a950ec4 
* NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple

* Light formatting

* remove added newline

* change to default

* diff nit

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@phated @kevaundray
feat: Add equality and serialization to poly_triple (#172)
142b041 
* NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple

* Light formatting

* remove added newline

* change to default

* diff nit

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@AztecBot AztecBot mentioned this pull request Mar 13, 2026
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalladino spalladino spalladino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spypsy @spalladino