Skip to content

fix: Download SRS using one canonical URL across the codebase #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevaundray merged 2 commits into from
Aug 22, 2023
Merged

fix: Download SRS using one canonical URL across the codebase #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5272269
use one URL and fix the off-by-one error
kevaundray Aug 22, 2023
e38b2f0
use sealed URL instead of monomial
kevaundray Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions circuits/cpp/barretenberg/cpp/src/barretenberg/bb/get_crs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ inline std::vector<uint8_t> download_g1_data(size_t num_points)

inline std::vector<uint8_t> download_g2_data()
{
size_t g2_start = 28 + 5040000 * 64;
size_t g2_start = 28 + 5040001 * 64;
size_t g2_end = g2_start + 128 - 1;
std::string command = "curl -s -H \"Range: bytes=" + std::to_string(g2_start) + "-" + std::to_string(g2_end) +
"\" 'https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/sealed/transcript00.dat'";
"\" 'https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/monomial/transcript00.dat'";

return exec_pipe(command);
}
Expand Down
4 changes: 2 additions & 2 deletions circuits/cpp/barretenberg/ts/src/crs/net_crs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ export class NetCrs {
* Download the G2 points data.
*/
async downloadG2Data() {
const g2Start = 28 + 5040000 * 64;
const g2Start = 28 + 5040001 * 64;
const g2End = g2Start + 128 - 1;

const response2 = await fetch('https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/sealed/transcript00.dat', {
const response2 = await fetch('https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/monomial/transcript00.dat', {
headers: {
Range: `bytes=${g2Start}-${g2End}`,
},
Expand Down
6 changes: 3 additions & 3 deletions yarn-project/circuits.js/src/crs/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class NetCrs {
const g1End = g1Start + this.numPoints * 64 - 1;

// Download required range of data.
const response = await fetch('https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/sealed/transcript00.dat', {
const response = await fetch('https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/monomial/transcript00.dat', {
Comment thread
kevaundray marked this conversation as resolved.
headers: {
Range: `bytes=${g1Start}-${g1End}`,
},
Expand All @@ -42,10 +42,10 @@ export class NetCrs {
* Download the G2 points data.
*/
async downloadG2Data() {
const g2Start = 28 + 5040000 * 64;
const g2Start = 28 + 5040001 * 64;
const g2End = g2Start + 128 - 1;

const response2 = await fetch('https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/sealed/transcript00.dat', {
const response2 = await fetch('https://aztec-ignition.s3.amazonaws.com/MAIN%20IGNITION/monomial/transcript00.dat', {
headers: {
Range: `bytes=${g2Start}-${g2End}`,
},
Expand Down