fix!: missing boolean constraints on zero checks targets#19401
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
dbanks12
requested review from
sirasistant
and removed request for
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
dbanks12
force-pushed
the
db/missing-zero-check-bools
branch
from
b90b0b2 to
18516b8
Compare
dbanks12
commented
Jan 7, 2026
Comment on lines
180
to
181
|
|
||
| #[SINGLE_TAG_ERROR_BOOLEAN] | ||
| single_tag_error * (1 - single_tag_error) = 0; | ||
|
|
||
| #[VAL01] |
Contributor
Author
There was a problem hiding this comment.
Duplicate constraint
jeanmon
approved these changes
Jan 7, 2026
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
BEGIN_COMMIT_OVERRIDE feat(avm)!: optionally use TS logger in C++ simulation (#19305) chore(avm): bytecode caching comments chore(avm): disable VK hash checking in tests fix(avm)!: instr_fetching soundness bug (#19381) fix(avm): dont catch wide exceptions (#19388) refactor(avm): Refactor get contract instance fuzzer backfill (#19387) feat(avm): mutate enqueued calls (#19315) chore(avm): migrate to BB asserts (#19395) fix!: more missing boolean constraints in calldata, calldata hashing, sha256 mem PILs (#19367) feat(avm): defensively assert cd hashes (#19346) chore: annotate booleans in PIL, and add some missing boolean constraints (#19371) fix!: missing boolean constraints on zero checks targets (#19401) fix!: context did not constrain returndata size to 0 at start, and had a misnamed relation (#19404) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And annotated some explicitly constrained booleans in these files while i was at it.
Also we had a duplicated boolean constraint in keccak_mem