Skip to content

feat(avm): use noop calldata hasher in fast sim #19495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fcarreiro merged 1 commit into from
Jan 12, 2026
+22 −2
Merged

feat(avm): use noop calldata hasher in fast sim #19495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions barretenberg/cpp/src/barretenberg/vm2/simulation/standalone/noop_calldata_hashing.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#pragma once

#include "barretenberg/vm2/simulation/interfaces/calldata_hashing.hpp"

namespace bb::avm2::simulation {

class NoopCalldataHasher : public CalldataHashingInterface {
public:
void assert_calldata_hash(const FF& /*cd_hash*/, std::span<const FF> /*calldata*/) override {}
};

class NoopCalldataHashingProvider : public CalldataHashingProviderInterface {
public:
std::unique_ptr<CalldataHashingInterface> make_calldata_hasher(uint32_t /*context_id*/) override
{
return std::make_unique<NoopCalldataHasher>();
}
};

} // namespace bb::avm2::simulation
4 changes: 2 additions & 2 deletions barretenberg/cpp/src/barretenberg/vm2/simulation_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
#include "barretenberg/vm2/simulation/standalone/concrete_dbs.hpp"
#include "barretenberg/vm2/simulation/standalone/debug_log.hpp"
#include "barretenberg/vm2/simulation/standalone/hybrid_execution.hpp"
#include "barretenberg/vm2/simulation/standalone/noop_calldata_hashing.hpp"
#include "barretenberg/vm2/simulation/standalone/noop_update_check.hpp"
#include "barretenberg/vm2/simulation/standalone/pure_alu.hpp"
#include "barretenberg/vm2/simulation/standalone/pure_bitwise.hpp"
Expand Down Expand Up @@ -404,7 +405,6 @@ TxSimulationResult AvmSimulationHelper::simulate_fast_internal(ContractDBInterfa
NoopEventEmitter<RangeCheckEvent> range_check_emitter;
NoopEventEmitter<ContextStackEvent> context_stack_emitter;
NoopEventEmitter<TxEvent> tx_event_emitter;
NoopEventEmitter<CalldataEvent> calldata_emitter;
NoopEventEmitter<InternalCallStackEvent> internal_call_stack_emitter;
NoopEventEmitter<ContractInstanceRetrievalEvent> contract_instance_retrieval_emitter;
NoopEventEmitter<GetContractInstanceEvent> get_contract_instance_emitter;
Expand Down Expand Up @@ -455,7 +455,7 @@ TxSimulationResult AvmSimulationHelper::simulate_fast_internal(ContractDBInterfa
PureExecutionComponentsProvider execution_components(greater_than, instruction_info_db);

PureMemoryProvider memory_provider;
CalldataHashingProvider calldata_hashing_provider(poseidon2, calldata_emitter);
NoopCalldataHashingProvider calldata_hashing_provider;
InternalCallStackManagerProvider internal_call_stack_manager_provider(internal_call_stack_emitter);
ContextProvider context_provider(tx_bytecode_manager,
memory_provider,
Expand Down
Loading