chore(avm)!: resolve execution TODOs#19501
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jeanmon
requested changes
Jan 12, 2026
jeanmon
left a comment
jeanmon
left a comment
Contributor
There was a problem hiding this comment.
Great changes. I think there is an undefined behavior but not due to your changes.
Could you please check this @fcarreiro ?
| // This helper handles operand conversion. In particular it converts enums to their underlying type first. | ||
| auto convert_operand = []<typename T>(const Operand& op) -> T { | ||
| if constexpr (std::is_enum_v<T>) { | ||
| return static_cast<T>(op.to<std::underlying_type_t<T>>()); |
|
|
||
| MemoryValue result; | ||
|
|
||
| EnvironmentVariable env_var = static_cast<EnvironmentVariable>(var_enum); |
Contributor
There was a problem hiding this comment.
Seems that is undefined behvior. https://stackoverflow.com/questions/33607809/can-an-out-of-range-enum-conversion-produce-a-value-outside-the-underlying-type
Not created by your PR @fcarreiro though but for this case I think we need keep the uint8_t value guarding by env_var <= EnvironmentVariable::MAX.
I think the tag is fine because it should have been filtered earlier in the read_instruction().
Contributor
There was a problem hiding this comment.
Collaborator
Flakey Tests🤖 says: This CI run detected 3 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
jeanmon
approved these changes
Jan 12, 2026
Contributor
Author
Merge activity
|
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
BEGIN_COMMIT_OVERRIDE feat(avm security): add static check for isolated/unused columns (#19489) feat(avm): use noop calldata hasher in fast sim (#19495) chore(avm): rename indirect -> addressing mode (#19491) chore(avm): small cursor optimizations chore(avm):! rename indirect -> addressing mode (PIL) (#19493) fix(avm): constraint when unwinding empty call stack (#19485) feat(avm): Fuzz debug log and refactor env getter (#19494) fix!: ecc add predicate completeness bug (#19471) chore(avm): callstackmetadatacollector clarifications (#19490) chore: sanity assert in execution for bytecode id (#19486) fix!: sstore allowed injection of malicious write rows (#19470) fix!: defensive ghost row constraints in bc_hashing pil (#19481) fix(avm): fix execution::mov for mac? (#19507) chore(avm)!: resolve execution TODOs (#19501) fix!: multiple traces had ghost row injection vulnerabilities (#19480) fix(avm): defensively copy MemoryValues (#19512) feat: align TS and BB log levels (#19518) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: MemoryTag can be used directly because it's validated during instruction fetching. For EnvironmentVariable, we need to use uint8_t until we do the proper validation.