feat(avm): protocol contractg mutations #19586
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| #include "barretenberg/avm_fuzzer/mutations/protocol_contracts.hpp" | ||
|
|
||
| #include "barretenberg/vm2/common/aztec_constants.hpp" | ||
| #include "barretenberg/vm2/common/aztec_types.hpp" | ||
|
|
||
| namespace bb::avm2::fuzzer { | ||
|
|
||
| namespace { | ||
|
|
||
| void update_enqueued_calls_for_protocol_contract(Tx& tx, | ||
|
Contributor
Author
There was a problem hiding this comment. this is a bit of a code-smell, but we need to update the addresses used in the enqueued calls whenever we modify the protocol contracts and we would have potentially invalidated addresses that are referenced by enqueued calls |
||
| const AztecAddress& prev_address, | ||
| const AztecAddress& new_address) | ||
| { | ||
| // Update setup_enqueued_calls | ||
| for (auto& call : tx.setup_enqueued_calls) { | ||
| if (call.request.contract_address == prev_address) { | ||
| call.request.contract_address = new_address; | ||
| } | ||
| } | ||
| // Update app_logic_enqueued_calls | ||
| for (auto& call : tx.app_logic_enqueued_calls) { | ||
| if (call.request.contract_address == prev_address) { | ||
| call.request.contract_address = new_address; | ||
| } | ||
| } | ||
| // Update teardown_enqueued_call | ||
| if (tx.teardown_enqueued_call.has_value() && tx.teardown_enqueued_call->request.contract_address == prev_address) { | ||
| tx.teardown_enqueued_call->request.contract_address = new_address; | ||
| } | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| void mutate_protocol_contracts(ProtocolContracts& protocol_contracts, | ||
| Tx& tx, | ||
| const std::vector<AztecAddress>& contract_addresses, | ||
| std::mt19937_64& rng) | ||
| { | ||
| if (contract_addresses.empty()) { | ||
| return; | ||
| } | ||
|
|
||
| auto choice = PROTOCOL_CONTRACTS_MUTATION_CONFIGURATION.select(rng); | ||
| switch (choice) { | ||
| case ProtocolContractsMutationOptions::Mutate: { | ||
| // Pick a random index and add a protocol contract | ||
| auto protocol_contract_index = std::uniform_int_distribution<size_t>(0, MAX_PROTOCOL_CONTRACTS - 1)(rng); | ||
| auto contract_address_index = std::uniform_int_distribution<size_t>(0, contract_addresses.size() - 1)(rng); | ||
|
|
||
| AztecAddress derived_address = contract_addresses[contract_address_index]; | ||
| protocol_contracts.derived_addresses[protocol_contract_index] = derived_address; | ||
|
|
||
| // The index of the protocol contracts array maps to canonical address. | ||
| // Add 1 because canonical addresses are 1-indexed | ||
| AztecAddress canonical_address(static_cast<uint256_t>(protocol_contract_index + 1)); | ||
|
|
||
| // todo(ilyas): there should be a more efficient way to do this | ||
| // Update any enqueued calls that reference the derived address to now use the canonical address | ||
| update_enqueued_calls_for_protocol_contract( | ||
| tx, /*prev_address=*/derived_address, /*new_address=*/canonical_address); | ||
| break; | ||
| } | ||
| case ProtocolContractsMutationOptions::Remove: { | ||
| // Pick an index, and zero it out, removing the protocol contract. It may already be zero but the fuzzer should | ||
| // figure out better mutations | ||
| size_t idx = std::uniform_int_distribution<size_t>(0, MAX_PROTOCOL_CONTRACTS - 1)(rng); | ||
| AztecAddress canonical_address(static_cast<uint256_t>(idx + 1)); | ||
| AztecAddress derived_address = protocol_contracts.derived_addresses[idx]; | ||
| // Update any enqueued calls that reference the canonical address to use the derived address | ||
| update_enqueued_calls_for_protocol_contract( | ||
| tx, /*prev_address=*/canonical_address, /*new_address=*/derived_address); | ||
| // Set the derived address to zero | ||
| protocol_contracts.derived_addresses[idx] = AztecAddress(0); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } // namespace bb::avm2::fuzzer | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #pragma once | ||
|
|
||
| #include "barretenberg/avm_fuzzer/common/weighted_selection.hpp" | ||
| #include "barretenberg/vm2/common/avm_io.hpp" | ||
| #include "barretenberg/vm2/common/aztec_types.hpp" | ||
|
|
||
| #include <random> | ||
|
|
||
| namespace bb::avm2::fuzzer { | ||
|
|
||
| enum class ProtocolContractsMutationOptions : uint8_t { | ||
| Mutate, | ||
| Remove, | ||
| }; | ||
|
|
||
| using ProtocolContractsMutationConfig = WeightedSelectionConfig<ProtocolContractsMutationOptions, 2>; | ||
|
|
||
| constexpr ProtocolContractsMutationConfig PROTOCOL_CONTRACTS_MUTATION_CONFIGURATION = ProtocolContractsMutationConfig({ | ||
| { ProtocolContractsMutationOptions::Mutate, 3 }, | ||
| { ProtocolContractsMutationOptions::Remove, 1 }, | ||
| }); | ||
|
|
||
| void mutate_protocol_contracts(bb::avm2::ProtocolContracts& protocol_contracts, | ||
| bb::avm2::Tx& tx, | ||
| const std::vector<AztecAddress>& contract_addresses, | ||
| std::mt19937_64& rng); | ||
|
|
||
| } // namespace bb::avm2::fuzzer |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so that when we look up the protocol contracts we can retrieve the instance