feat: merge-train/avm#19901
Merged
Merged
Conversation
SLOAD now requires the address of the state holder.
) Resolves https://linear.app/aztec-labs/issue/AVM-208/wrap-calldatareturndata-in-ts-simulator-in-a-lazy-reader-class Adds an interface for lazily read calldata and returndata. Creates two classes that implement the interface, an array backed one and a memory backed one. Internal calls use the memory backed one and the top level calldata uses the array backed one. In the memory one, memory is accessed at read time, instead of at creation time like we did before. This should fix the largest diff that we have right now between the TS and CPP versions of the simulator, that is the lazy behavior of calldata and returndata, unblocking the differential fuzzer.
AztecBot
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
After adding some cases to normalise/check for points at infinity in #19462 & #19471, I found the gadget fuzzer coverage didn't reach a few lines. This small fix ensures we set infinity in some mutations and we _don't_ normalise in all cases (to check error handling). (There is still, and always was, a normalised case where the scalar == 0, so we handled the (0, 0) inf representation)
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Improvement in fuzzer coverage
sirasistant
requested review from
IlyasRidhuan,
LeilaWang,
Maddiaa0 and
jeanmon
as code owners
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
1 similar comment
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: SLOAD fuzzing after configurable addr (#19895)
fix(avm): Make the TS simulator lazy read calldata / return data (#19843)
chore(avm): ECC pre-audit gadget fuzzing (#19739)
fix: Fuzzer sometimes creates to radix with num_limbs=0 (#19929)
fix: Enforce recipients of l2l1msgs having 20 bytes at most (#19898)
fix merge conflict
END_COMMIT_OVERRIDE