feat: support JSON input files for bb verify command (v2)#19966
Merged
Conversation
- Add type-specific JSON structs (VkJson, ProofJson, PublicInputsJson) with named fields - Auto-detect JSON vs binary format in verify command - Update bootstrap.sh to use new field names (.vk, .proof, .public_inputs, .hash) - Suppress nlohmann/json sign-conversion warnings for WASM builds
a340df7 to
e2cf771
Compare
Contributor
Author
|
Size impact of adding nlohmann/json parsing support to native
Negligible impact. |
ludamad
approved these changes
Jan 28, 2026
ludamad
left a comment
Collaborator
There was a problem hiding this comment.
lgtm but what is the added size to the WASM?
Contributor
Author
|
Updated with WASM size impact:
Both are negligible. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
## Summary - Re-land of #19800 with fixes for WASM build and bootstrap.sh field names - Add type-specific JSON structs (VkJson, ProofJson, PublicInputsJson) with named fields per review feedback - Auto-detect JSON vs binary format in verify command - Update bootstrap.sh to use new field names (.vk, .proof, .public_inputs, .hash) - Suppress nlohmann/json sign-conversion warnings for WASM builds using pragma ## Size Impact | Build | Without nlohmann/json | With nlohmann/json | Difference | |-------|----------------------|-------------------|------------| | Native `bb` | 63.18 MB | 63.20 MB | **+19 KB (0.03%)** | | WASM `bb` | 13.49 MB | 13.52 MB | **+30 KB (0.22%)** | ## Test plan - [x] Native build passes - [x] WASM build passes (with `--target bb`) - [x] `regenerate_recursive_inputs` passes - [x] JSON prove and verify works end-to-end
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Size Impact
bbbbTest plan
--target bb)regenerate_recursive_inputspasses