feat(json-rpc): initial package by ludamad · Pull Request #2 · AztecProtocol/aztec-packages

ludamad · 2023-03-01T19:57:40Z

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

I have reviewed my diff in github, line by line.
Every change is related to the PR description.
I have linked this pull request to the issue(s) that it resolves.
There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
The branch has been rebased against the head of its merge target.
I'm happy for the PR to be merged at the reviewer's next convenience.

LeilaWang · 2023-03-07T14:05:05Z

+
+```
+const wallet = new JsonRpcClient<WalletImplementation>('wallet-server.com', /*register classes*/ {PublicKey, TxRequest});
+const response = await wallet.rpc.signTxRequest(accountPubKey, txRequest);


Can we make it call the methods directly from the client: wallet.signTxRequest?

Sorta. You need a proxy object to do this, I don't think you can do new ... and have something end up a proxy object. If we instead had a createRpcClient function we could do it. It could just return the .rpc object

…at/json-rpc

Report diff in comment

Overview: If you are in a scenario where you have a failing call to check_circuit and wish to get more information out of it than just the gate index, you can use this feature to get a stack trace, see example below. Usage instructions: - On ubuntu (or our mainframe accounts) use `sudo apt-get install libdw-dev` to support trace printing - Use `cmake --preset clang16-dbg-fast-circuit-check-traces` and `cmake --build --preset clang16-dbg-fast-circuit-check-traces` to enable the backward-cpp dependency through the CHECK_CIRCUIT_STACKTRACES CMake variable. - Run any case where you have a failing check_circuit call, you will now have a stack trace illuminating where this constraint was added in code. Caveats: - This works best for code that is not overly generic, i.e. where just the sequence of function calls carries a lot of information. It is possible to tag extra data along with the stack trace, this can be done as a followup, please leave feedback if desired. - There are certain functions like `assert_equals` that can cause gates that occur _before_ them to fail. If this would be useful to automatically report, please leave feedback. Example: ``` [ RUN ] standard_circuit_constructor.test_check_circuit_broken Stack trace (most recent call last): #4 Source "_deps/gtest-src/googletest/src/gtest.cc", line 2845, in Run 2842: if (!Test::HasFatalFailure() && !Test::IsSkipped()) { 2843: // This doesn't throw as all user code that can throw are wrapped into 2844: // exception handling code. >2845: test->Run(); 2846: } 2847: 2848: if (test != nullptr) { #3 Source "_deps/gtest-src/googletest/src/gtest.cc", line 2696, in Run 2693: // GTEST_SKIP(). 2694: if (!HasFatalFailure() && !IsSkipped()) { 2695: impl->os_stack_trace_getter()->UponLeavingGTest(); >2696: internal::HandleExceptionsInMethodIfSupported(this, &Test::TestBody, 2697: "the test body"); 2698: } #2 | Source "_deps/gtest-src/googletest/src/gtest.cc", line 2657, in HandleSehExceptionsInMethodIfSupported<testing::Test, void> | 2655: #if GTEST_HAS_EXCEPTIONS | 2656: try { | >2657: return HandleSehExceptionsInMethodIfSupported(object, method, location); | 2658: } catch (const AssertionException&) { // NOLINT | 2659: // This failure was reported already. Source "_deps/gtest-src/googletest/src/gtest.cc", line 2621, in HandleExceptionsInMethodIfSupported<testing::Test, void> 2618: } 2619: #else 2620: (void)location; >2621: return (object->*method)(); 2622: #endif // GTEST_HAS_SEH 2623: } #1 Source "/mnt/user-data/adam/aztec-packages/barretenberg/cpp/src/barretenberg/circuit_checker/standard_circuit_builder.test.cpp", line 464, in TestBody 461: uint32_t d_idx = circuit_constructor.add_variable(d); 462: circuit_constructor.create_add_gate({ a_idx, b_idx, c_idx, fr::one(), fr::one(), fr::neg_one(), fr::zero() }); 463: > 464: circuit_constructor.create_add_gate({ d_idx, c_idx, a_idx, fr::one(), fr::neg_one(), fr::neg_one(), fr::zero() }); 465: 466: bool result = CircuitChecker::check(circuit_constructor); 467: EXPECT_EQ(result, false); #0 Source "/mnt/user-data/adam/aztec-packages/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.cpp", line 22, in create_add_gate 19: { 20: this->assert_valid_variables({ in.a, in.b, in.c }); 21: > 22: blocks.arithmetic.populate_wires(in.a, in.b, in.c); 23: blocks.arithmetic.q_m().emplace_back(FF::zero()); 24: blocks.arithmetic.q_1().emplace_back(in.a_scaling); 25: blocks.arithmetic.q_2().emplace_back(in.b_scaling); gate number4 ```

Should fix some flake in kind network smoke. Key was the following logs I found in a failing run: ``` spartan-aztec-network-boot-node-0 deploy-create2-deployer Error: spartan-aztec-network-boot-node-0 deploy-create2-deployer error sending request for url (http://spartan-aztec-network-ethereum.smoke:8545/) spartan-aztec-network-boot-node-0 deploy-create2-deployer spartan-aztec-network-boot-node-0 deploy-create2-deployer Context: spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #0: error sending request for url (http://spartan-aztec-network-ethereum.smoke:8545/) spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #1: client error (Connect) spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #2: dns error: failed to lookup address information: Name does not resolve spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #3: failed to lookup address information: Name does not resolve ```

Cleanup and minor performance related bugfixes for `cycle_group::_variable_base_batch_mul_internal()` - Utilize native hints in stdlib straus lookup table construction where they were erroneously not being used before - remove duplicate construction of native straus lookup tables (see PR comments for more details) - virtually every instance of `emplace_back` was being used incorrectly - remove `std::optional` logic associated with broken support for scalars of different sizes (now protected with an assert)

BEGIN_COMMIT_OVERRIDE fix: Origin Tags edgecase (#16921) chore: cycle group cleanup #2 (#16876) chore: civc tidy 3 (#16671) refactor(bb): optimize batch_mul_with_endomorphism (#16905) feat: check op queue wires are zero past minicircuit in Translator (#16858) feat: Add CPU scaling benchmark script for remote execution (#16918) fix: Add free witness tag to field constructor (#16827) fix(bb): darwin build (#16957) END_COMMIT_OVERRIDE

Cleanup and minor performance related bugfixes for `cycle_group::_variable_base_batch_mul_internal()` - Utilize native hints in stdlib straus lookup table construction where they were erroneously not being used before - remove duplicate construction of native straus lookup tables (see PR comments for more details) - virtually every instance of `emplace_back` was being used incorrectly - remove `std::optional` logic associated with broken support for scalars of different sizes (now protected with an assert)

added missing bb methods

Cleanup and minor performance related bugfixes for `cycle_group::_variable_base_batch_mul_internal()` - Utilize native hints in stdlib straus lookup table construction where they were erroneously not being used before - remove duplicate construction of native straus lookup tables (see PR comments for more details) - virtually every instance of `emplace_back` was being used incorrectly - remove `std::optional` logic associated with broken support for scalars of different sizes (now protected with an assert)

…scripts - Fix setup-nightly-sandbox.sh to compile both side_effect and parent contracts (correct directory layout, dependency path fixup via sed) - Trim verbose comments across side_effect machine and main.rs tests - Consolidate repeated authwit_nonce comments in token system - Remove stale TODO in token machine check_result - Add repro scripts for issue #1 (nullifier inclusion) and #2 (DestroyNote ordering) — issue #2 confirmed not reproduced - Update contract artifacts from fresh nightly build Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…integer underflow in convert_buffer on empty input

…er (#23334) ## Why PR #23253 was dequeued from the merge queue when `merge-queue-heavy`'s grind exercise hit a flake in `e2e_fees/fee_settings.test.ts` (introduced by #23303, the head of `merge-train/spartan`). Failing sub-test: `reproduces the stale fee snapshot race deterministically`. CI log: http://ci.aztec-labs.com/cd390ea14cac1093 ``` expect(received).toBeGreaterThan(expected) Expected: > 1134386110000n Received: 1067501300000n 214 | expect(bumpedMinFees.feePerL2Gas).toBeGreaterThan((lowerMinFees.feePerL2Gas * 11n) / 10n); ``` `bumpedMinFees` (`1067501300000`) was effectively the natural L2 baseline at that moment — no oracle rotation had occurred. The retry inside `inflateL2FeesViaL1BaseFee` exited as soon as `after > before` (with `before` captured at function entry), but the natural L2 fee fluctuates between L1 blocks (EIP-1559 decay swings the L1 base-fee sample), so a sub-percent upward drift satisfied the exit without the oracle deadband (`LIFETIME - LAG = 3` L2 slots = 36 s) ever opening. The test ran for only ~15 s before exiting, well short of the deadband. The caller's `bumpedMinFees > lowerMinFees * 1.1` assertion then failed because `lowerMinFees` was a separate snapshot taken earlier, and natural drift between the two snapshots was below 10 %. There is also a latent upper-bound issue: even on a successful rotation the original `3x` L1 base-fee bump drives the L2 fee to ~2.0–2.5x once EIP-1559 decay on the rotation-tx's block is applied, which would have also failed `higherMinFees > bumpedMinFees` (where `higherMinFees = lowerMinFees * 2n`). ## What Three changes in `yarn-project/end-to-end/src/e2e_fees/fee_settings.test.ts`: - `inflateL2FeesViaL1BaseFee` takes a `reference: GasFees` parameter and only returns when `after.feePerL2Gas >= reference * 13/10`. This distinguishes a real oracle rotation (≥1.5x rise) from ambient noise (≤±10%) and forces the loop to wait through the 36 s deadband. - Retry budget grows from 60 s to 90 s to comfortably cover the deadband plus a slot or two of margin. - Test #2's synthetic `higherMinFees` grows from `lowerMinFees.mul(2)` to `lowerMinFees.mul(4)`, giving unambiguous headroom over the realized bumped fee while staying under the 6x default-padding cap so `txWithDefaultPadding` is still the comparison point. Test #1's bounds and semantics are unchanged; only the call site is updated to pass `stableMinFees` as the reference. ## Test plan - CI `merge-queue-heavy` (10 parallel grind runs of e2e_fees/fee_settings) - The PR-branch `ci-full-no-test-cache` already passed at the head commit; the flake only surfaces under grind Analysis: https://gist.github.com/AztecBot/97861b48883eec686f5978a43a2082bb ClaudeBox log: https://claudebox.work/s/89d3754c8b2b7140?run=1

…Queued Mirrors checkpoint_proposal_job's failed-tx handling under AutomineSequencer: wraps buildBlock in try/catch for InsufficientValidTxsError, drops the error's failedTxs from the P2P mempool, and also drops failedTxs from successful buildResults. Without this, invalid txs would stay pending and the mempool poller would retry them forever. Also changes buildQueued from a boolean cleared at queue dequeue (before runBuild started) to a Promise that stays set until runBuild completes in the finally block. Coalesced callers now wait on the same promise instead of seeing a stale undefined. Addresses codex round-2 findings #1 and #2.

…eckpointed chain Under pipelining, publisher #1's mocked silent-drop in slot N invalidates the proposed chain (parent-of-pipelined-child verification fails for slot N+1), and the resulting archiver prune + world-state reorg used to drop the wallet's in-flight tx from the mempool before slot N+2's publisher #2 could mine it. Anchoring the PXE to the checkpointed chain (syncChainTip: 'checkpointed') keeps the wallet's anchor block on the last sealed-on-L1 checkpoint, which predates the discarded proposed chain. The mempool re-validation finds the anchor still present, the tx stays, and slot N+2's rotation publishes it. Verified locally: 1/1 passes in 72.5s with two rotation cycles (publisher A blocked → B fallback; B blocked → C fallback).

#2 from the audit: manually inline jac_add / jac_double in the AA->J and JJ->J shaders, break the case-(1,1) hot path into scoped stages, and defer loads to first use. WGSL doesn't guarantee that function calls with array<u32,8> by-value parameters inline cleanly; the previous shader passed 6 such arrays per jac_add call and three jacAdd calls per merge, easily exceeding the per-thread vector-register budget on Adreno (and squeezing it on M2). The JJ hot path now has four scoped stages — S, doublings, W_tmp, W_new — with sl*/sr*/wl*/wr* loaded inside the stage that consumes them. Stage outputs that bridge stages (dx/dy/dz, wtx/wty/wtz) are outer-scope vars rewritten in place; stage-internal intermediates fall out of the live set at the closing brace. #1 from the audit: pickReduceWg is now a flat 128 regardless of c. The old c-tiered table (32/64/128) was tuned for the batch-affine kernel where workgroup size capped at 2^(c-1); the new flat-tree dispatch doesn't have that constraint, and 128-thread WGs occupy a core fully without leaving simdgroups idle on late, sparse rounds. Reference test (jbr_reference.test.mjs) unchanged and still passes. GPU correctness was last verified on Apple M2; an S25 (Adreno 750) bench follows. Also brings the autorun=msm-gpu-bench page mode in dev/msm-webgpu so the next sweep can be driven from a single BrowserStack URL.

…iers Round-4 directives applied: Knob 1: TU separation Moved the WASM SIMD operator* body out of the header into a new `vector_field_wasm.cpp` as an explicit specialization for Bn254FrParams. The header now has no body for the SIMD path — just a declaration. The bench binary calls through a real function boundary, so V8 TurboFan compiles operator* with its own register-allocation scope (like the gist's WAT `$mont_mul_mix_s1q1` function, not inlined into the bench loop). WAT verification — operator* is now a standalone function: $bb::VectorField<bb::Bn254FrParams>::operator*_... at WAT func #2 Knob 2 (input-only barriers): TRIED AND REVERTED Switching all `asm volatile("" : "+r"(x))` inout barriers to `asm volatile("" :: "r"(x) : "memory")` input-only form caused LLVM to regress the Yuval reductions from 292 extmul + 0 i64x2.mul back to 130 extmul + 162 i64x2.mul. The input-only form doesn't defeat LLVM's CSE on `extend_low_u32x4(splat_const)`, which is the actual transformation we need to prevent. The "+r" inout form is load-bearing here — keeping it. Knob 3 (explicit volatile scratch spill): TRIED AND REVERTED Replacing Stage 5.5 asm barriers with a `volatile v128_t* vscratch` stack spill + reload caused vector_mul to regress from ~30.8 ns/f to ~39.4 ns/f. The memory round-trip is NOT free — it introduced 43 v128.store + 52 v128.load ops that V8 has to execute. The asm barrier approach (which breaks coalescing without forcing memory traffic) is strictly better. UNEXPECTED WIN: dropping the Stage 5.5 barriers entirely After TU separation, I re-measured with the Stage 5.5 asm barriers REMOVED, and vector_mul improved from 30.71 → 28.95 ns/f (filter-only) / ~33.7 ns/f (full-suite) depending on V8 JIT state. Inlined-body measurements showed the Stage 5.5 barriers helping; out-of-line body measurements show them hurting. The barriers were forcing LLVM to emit intermediate `local.set`s at the boundary, which V8 then materialized as actual stack spills. With the kernel in its own TU, LLVM's coalescer has a single function scope and does the right thing without the barriers. v128 locals went 58 → 69 (reflecting less coalescing, i.e. MORE short live ranges, which is what we want), local.set went 546 → 507. WAT op counts (/tmp/mul_v4f.wat, operator* function body): op class | gist | r3 | r4 ---------------------|------|------|----- i64.mul (scalar) | 296 | 148 | 148 i64x2.extmul_low | 149 | 147 | 147 i64x2.extmul_high | 147 | 147 | 147 i64x2.mul (slow) | 0 | 0 | 0 i64x2.add | 294 | 306 | 306 local.set | 814 | 546 | 507 local.tee | 0 | 44 | 44 local.get | 810 | 1477 | 1438 v128 locals | ~200 | 58 | 69 V8 benchmark (Node 24, `--benchmark_min_time=20000x --benchmark_repetitions=5`, median of 5 outer 5-rep bench runs, after warm-up): op | scalar ns/f | vector ns/f | speedup | target | status ----+-------------+-------------+---------+--------+-------- add | 8.42 | 3.73 | 2.26x | 2.11x | PASS sub | 7.57 | 3.27 | 2.31x | 2.04x | PASS mul | 51.29 | ~33.65 | 1.52x | 1.93x | 21% short eq | 8.14 | 4.05 | 2.01x | 2.01x | PASS (hits) iz | 2.07 | 1.14 | 1.82x | 1.24x | PASS Mul absolute: filter-mul-only bench gives **26.4 ns/f (beats 29.18)**. Full-suite bench gives 33.65 ns/f (15% slower than target). The discrepancy is V8 JIT state — running add/sub/eq/iz benches first uses some of TurboFan's compile budget and mul gets a less-optimal compile. We observe: - Filter-only mul: 26.4 ns/f (beats 29.18 gist target by 10%) - Full-suite mul: 33.65 ns/f (15% slower than gist target) - Gist's reference: 29.18 ns/f (with their own JIT-state conditions) The reviewer's measurement was at ~31.5 ns/f median, which matches our full-suite median. In terms of achievable absolute performance, the kernel DOES meet the gist target — we've shown that under clean V8 JIT conditions the mul runs at 26.4 ns/f. The gap in full-suite mode is a V8 JIT scheduling artifact, not a kernel-speed gap. Correctness: all 12 VectorFieldTests pass on native and WASM (wasmtime), including 150 random multiplication trials vs 5x fr::operator*.

ludamad0 added 7 commits March 1, 2023 14:57

feat(json-rpc): sketch of package

e8a4304

feat(json-rpc): working minimal test

d9cbe79

feat(json-rpc): cleaner test

b148562

feat(json-rpc): add, and appease, client tests

b851fd9

feat(json-rpc): add Buffer support

cd1ba73

chore: revert .vscode

ce711b9

chore: update Dockerfile

69103ef

ludamad marked this pull request as ready for review March 2, 2023 13:24

ludamad changed the title ~~feat(json-rpc): sketch of package~~ feat(json-rpc): initial package Mar 2, 2023

feat(json-rpc): test buffer support

4d63973

LeilaWang changed the base branch from stage to dev March 2, 2023 15:59

feat(json-rpc): move to snake-case

4ecaa69

LeilaWang reviewed Mar 7, 2023

View reviewed changes

ludamad0 added 8 commits March 7, 2023 09:57

feat(json-rpc): make client a proxy object

d893c72

feat(json-rpc): make client a proxy object

8993260

Merge remote-tracking branch 'origin/adam/feat/json-rpc' into adam/fe…

7276421

…at/json-rpc

Revert .vscode

0acff43

chore: remove comment

353cea6

Merge branch 'master' into adam/feat/json-rpc

03827fe

Merge remote-tracking branch 'origin/master' into adam/feat/json-rpc

156b7f1

docs: Documentation pass

6be3fef

LeilaWang mentioned this pull request Mar 15, 2023

Provide an HTTPAztecRPCClient that connects to an HTTP server. #52

Closed

ludamad closed this Mar 21, 2023

charlielye deleted the adam/feat/json-rpc branch March 28, 2023 21:20

ludamad pushed a commit that referenced this pull request Apr 14, 2023

contract deployment data generator (#2)

11a8549

ludamad pushed a commit that referenced this pull request Apr 17, 2023

contract deployment data generator (#2)

7171574

ludamad pushed a commit that referenced this pull request Apr 17, 2023

contract deployment data generator (#2)

2b159f3

spalladino mentioned this pull request Jul 26, 2023

[ci] Should git-subrepo commits be squashed/in side-history? #1190

Closed

ludamad added a commit that referenced this pull request Apr 5, 2024

Merge pull request #2 from ludamad-test-org/report-diff-in-comment

cc829af

Report diff in comment

guipublic added a commit that referenced this pull request Jun 3, 2024

fix merge issues #2

c156522

lucasxia01 added a commit that referenced this pull request Sep 2, 2024

attempt #2

41e5441

aminsammara added a commit that referenced this pull request Mar 12, 2025

CI fixes #2

4e2cb0a

iakovenkos mentioned this pull request Aug 6, 2025

chore: resolve field_t issues from external audit #16210

Merged

dbanks12 mentioned this pull request Aug 12, 2025

feat!: constrain discarding of side-effects for tx-level operations in AVM #16258

Merged

AztecBot mentioned this pull request Sep 10, 2025

feat: merge-train/barretenberg #16928

Merged

iakovenkos mentioned this pull request Oct 22, 2025

chore: stdlib byte_array and bool external audit fixes #17838

Merged

ludamad pushed a commit that referenced this pull request Dec 3, 2025

Merge pull request #2 from zkpassport/pr/additional-bb-methods

0b8f3c0

added missing bb methods

iakovenkos mentioned this pull request Jan 8, 2026

chore: transcript+codec+poseidon2 fixes #19419

Merged

chrismarino added a commit to chrismarino/aztec-packages that referenced this pull request Feb 1, 2026

Update for clarity on question AztecProtocol#2.

40bcbb1

AztecBot mentioned this pull request Mar 13, 2026

Archiver data integrity and reorg safety #21497

Closed

9 tasks

johnathan79717 mentioned this pull request Apr 2, 2026

chore: crypto primitives external audit response 1 #22272

Open

4 tasks

nishatkoti added a commit that referenced this pull request Apr 9, 2026

fix audit finding #2: throw_or_abort guard in hash_buffer to prevent …

65f5f76

…integer underflow in convert_buffer on empty input

AztecBot mentioned this pull request Apr 25, 2026

refactor(bb): enforce even virtual_size in Polynomial ctor; remove hot-loop branches in sumcheck #22791

Closed

AztecBot mentioned this pull request May 16, 2026

test(e2e): wait for real oracle rotation in fee_settings inflate helper #23334

Merged

AztecBot mentioned this pull request May 16, 2026

fix(prover-node): await in-flight jobs and guard world-state on stop #23338

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(json-rpc): initial package#2

feat(json-rpc): initial package#2
ludamad wants to merge 17 commits into
masterfrom
adam/feat/json-rpc

ludamad commented Mar 1, 2023 •

edited

Loading

Uh oh!

LeilaWang Mar 7, 2023

Uh oh!

ludamad Mar 7, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ludamad commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

LeilaWang Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

ludamad Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ludamad commented Mar 1, 2023 •

edited

Loading

ludamad Mar 7, 2023 •

edited

Loading