fix(e2e): enable broadcastEquivocatedProposals in duplicate proposal slash test#20320
Merged
spalladino merged 1 commit intoFeb 9, 2026
Merged
Conversation
PhilWindle
approved these changes
Feb 9, 2026
…slash test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
spalladino
force-pushed
the
palla/fix-duplicate-proposal-slash-test
branch
from
2947cce to
e4f19ed
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
BEGIN_COMMIT_OVERRIDE chore: add new retention policy to cloudflare R2 (#20276) fix: k8s enricher opt-in (#20279) feat(slasher): add duplicate attestation slashing (#20218) chore: improve HA e2e (#20280) chore(test): fix p2p integration test (#20283) chore(claude): minor changes to claude md and rules (#20284) chore(test): fix p2p message propagation test build error (#20289) chore(claude): add actor info to analyze-logs (#20290) feat: tx file store source for tx collector (#20165) chore(test): fix validator integration test (#20288) chore(e2e): remove setup with remote env in e2e tests (#20294) chore: fix test flakes (#20295) chore: user-perceived latency explorer (#20298) fix(p2p): fix flaky file store tx collection tests (#20318) chore(spartan): add mbps-net env definition (#20308) fix(validator): do not process proposals from self (#20314) chore(ci): track history in merge-trains (#20321) fix(e2e): enable broadcastEquivocatedProposals in duplicate proposal slash test (#20320) chore: use respective get endpoints for rollup test instead of only port-forward (#20327) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e_p2p_duplicate_proposal_slashtest was flaking because malicious nodes were not actually broadcasting duplicate proposals to the network.P2PClient.broadcastProposal()method throws when it detects a duplicate block proposal for the same slot, unlessbroadcastEquivocatedProposalsis set totrue.broadcastEquivocatedProposals: trueto both malicious node configs, matching what theduplicate_attestation_slashtest already does.Test plan
e2e_p2p_duplicate_proposal_slashtest should now pass reliably since the duplicate proposals will actually reach the network and be detected by the slasher.🤖 Generated with Claude Code