fix: (A-370) don't propagate on tx mempool add failure#20374
Merged
PhilWindle merged 1 commit intoFeb 10, 2026
Merged
Conversation
danielntmd
commented
Feb 10, 2026
danielntmd
commented
Contributor
- On gossip tx handling, first checks if it can be added to the pool before propagation
- tests to enforce this behavior
danielntmd
changed the title
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
danielntmd
changed the title
PhilWindle
requested changes
Feb 10, 2026
| // Check for debug drop for testing | ||
| const txHash = tx.getTxHash(); | ||
| const txHashString = txHash.toString(); | ||
| if (this.config.dropTransactions && randomInt(1000) < this.config.dropTransactionsProbability * 1000) { |
Collaborator
There was a problem hiding this comment.
I think we should remove this for the time being. The purpose of this debug flag is to propagate the transaction but internally we discard it. But I will add this to the transaction pool itself.
Contributor
Author
There was a problem hiding this comment.
Sounds good, removed.
danielntmd
force-pushed
the
danielntmd/void-propagation-on-tx-pool-add-failure-rebased
branch
2 times, most recently
from
08cb92a to
6a5a2e5
Compare
- On gossip tx handling, first checks if it can be added to the pool before propagation - tests to enforce this behavior
danielntmd
force-pushed
the
danielntmd/void-propagation-on-tx-pool-add-failure-rebased
branch
from
6a5a2e5 to
6f71ad9
Compare
PhilWindle
approved these changes
Feb 10, 2026
PhilWindle
deleted the
danielntmd/void-propagation-on-tx-pool-add-failure-rebased
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
BEGIN_COMMIT_OVERRIDE chore(ci3): add optional local cache for bootstrap artifacts (#20305) fix: Fix p2p integration test (#20331) chore: reduce fee log severity (#20336) feat: restrict response sizes to expected sizes (#20287) feat: retry web3signer connection (#20342) feat(p2p): Integrate TxPoolV2 across codebase (#20172) feat: review and optimize Claude configuration, agents, and skills (#20270) fix(prover): handle cross-chain messages when proving mbps (#20354) chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail (#19322) chore(p2p): add mock reqresp layer for tests (#20370) fix: (A-370) don't propagate on tx mempool add failure (#20374) chore: Skip the HA test (#20376) feat: Retain pruned transactions until pruned block is finalised (#20237) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.