Skip to content

fix: add missing avm-transpiler-cross-arm64-linux Makefile target#20920

Closed
AztecBot wants to merge 2 commits into
nextfrom
claudebox/368dc57b68117599-1
Closed

fix: add missing avm-transpiler-cross-arm64-linux Makefile target#20920
AztecBot wants to merge 2 commits into
nextfrom
claudebox/368dc57b68117599-1

Conversation

@AztecBot

@AztecBot AztecBot commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Makefile: The bb-cpp-cross-arm64-linux target depended on avm-transpiler-native instead of a cross-compiled arm64-linux avm-transpiler, so the cross-compiled libavm_transpiler.a was never built. Adds the missing avm-transpiler-cross-arm64-linux target and fixes the dependency.
  • barretenberg-rs release: The release function would error out if generated Rust bindings (api.rs, generated_types.rs) weren't present, even though it's trivial to generate them. Now generates them on-the-fly instead of failing.

Follows up on #20814 which added avm-transpiler arm64-linux support.

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Feb 26, 2026
@ludamad ludamad added ci-draft Run CI on draft PRs. ci-release-pr Creates a development tag and runs the release suite ci-squash-and-merge labels Feb 26, 2026
@ludamad ludamad marked this pull request as ready for review February 26, 2026 21:12
@ludamad ludamad enabled auto-merge February 26, 2026 21:13
@AztecBot AztecBot removed the ci-release-pr Creates a development tag and runs the release suite label Feb 26, 2026
@AztecBot AztecBot force-pushed the claudebox/368dc57b68117599-1 branch from fbef6bf to 7433672 Compare February 26, 2026 21:15
## Summary
- The `bb-cpp-cross-arm64-linux` Makefile target depended on `avm-transpiler-native` instead of a cross-compiled arm64-linux avm-transpiler
- This caused `ninja` to fail because `libavm_transpiler.a` was missing at the `aarch64-unknown-linux-gnu` target path
- Adds the missing `avm-transpiler-cross-arm64-linux` target and fixes the dependency so the correct cross-compiled library is built before the barretenberg ARM64 Linux link step

Follows up on #20814 which added avm-transpiler arm64-linux support to `bootstrap.sh` and `CMakePresets.json`, but the Makefile (introduced later) was never wired up.

[ClaudeBox log](http://ci.aztec-labs.com/368dc57b68117599-1)
@AztecBot AztecBot force-pushed the claudebox/368dc57b68117599-1 branch from 7433672 to e5d78e3 Compare February 26, 2026 21:20
The barretenberg-rs release function would fail if generated files
(api.rs, generated_types.rs) weren't present, even though it knows
how to generate them. Now it generates them on-the-fly instead of
erroring out.
@ludamad ludamad added the ci-release-pr Creates a development tag and runs the release suite label Feb 27, 2026
@AztecBot AztecBot removed the ci-release-pr Creates a development tag and runs the release suite label Feb 27, 2026
@ludamad ludamad closed this Feb 27, 2026
auto-merge was automatically disabled February 27, 2026 02:59

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants