fix(avm)!: memory trace changes#21059
Merged
IlyasRidhuan merged 1 commit intoMar 4, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/03-03-fix_avm_memory_trace_changes
branch
from
2176084 to
d67719e
Compare
IlyasRidhuan
force-pushed
the
ir/02-26-fix_avm_memory_pre-audit
branch
from
0d782f1 to
30b4ef7
Compare
IlyasRidhuan
requested review from
Maddiaa0,
fcarreiro and
jeanmon
as code owners
jeanmon
approved these changes
Mar 4, 2026
jeanmon
left a comment
jeanmon
left a comment
Contributor
There was a problem hiding this comment.
Great change and readability is as good IMHO!
IlyasRidhuan
force-pushed
the
ir/03-03-fix_avm_memory_trace_changes
branch
from
d67719e to
8ee4134
Compare
IlyasRidhuan
force-pushed
the
ir/02-26-fix_avm_memory_pre-audit
branch
from
30b4ef7 to
5d2649e
Compare
IlyasRidhuan
force-pushed
the
ir/03-03-fix_avm_memory_trace_changes
branch
from
8ee4134 to
c22225f
Compare
IlyasRidhuan
force-pushed
the
ir/02-26-fix_avm_memory_pre-audit
branch
from
5d2649e to
b03a30f
Compare
Base automatically changed from
ir/02-26-fix_avm_memory_pre-audit
to
merge-train/avm
March 4, 2026 16:42
IlyasRidhuan
force-pushed
the
ir/03-03-fix_avm_memory_trace_changes
branch
from
c22225f to
8cc74ae
Compare
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
BEGIN_COMMIT_OVERRIDE fix(avm)!: memory pre-audit (#21058) fix(avm)!: memory trace changes (#21059) fix!: AVM was missing range check on remainder for div in ALU (#21074) feat: run AVM NAPI simulations on dedicated threads instead of libuv pool (#21138) feat(avm)!: Unify nullifier, written slots and retrieved bytecodes tree traces (#20949) fix(avm)!: public inputs pre-audit (#21162) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we don't need to commit to the
timestampor theglobal_addrcolumns.Lots of changes mostly in tests to sidestep the fact we no longer have those columns