feat: improve oracle name prefixes (backport #21101)#21135
Closed
AztecBot wants to merge 2 commits into
Closed
Conversation
Add `aztec` namespace prefix and shorten scope prefixes for oracle names: - `utility` → `aztec_utl_` - `private` → `aztec_prv_` - `avmOpcode` → `aztec_avm_` - `txe` → `aztec_txe_` Strip prefixes from TS handler interfaces and implementations, keeping them only at the ACIR boundary (Oracle class and RPCTranslator). Bump ORACLE_VERSION to 13. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ludamad
force-pushed
the
backport-to-v4-staging
branch
2 times, most recently
from
9221e1a to
be9b609
Compare
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21101 to v4.
This adds the
aztecnamespace prefix to all oracles and shortens scope prefixes:utility→aztec_utl_private→aztec_prv_avmOpcode→aztec_avm_txe→aztec_txe_Conflict resolution: The cherry-pick had a conflict in
private_execution_oracle.tswhere v4 had refactoredthis.log→this.loggerand hadexpandedScopesas a computed local variable. Resolved by keeping v4'sthis.loggerandexpandedScopeswhile applying the PR's other changes.ClaudeBox log: http://ci.aztec-labs.com/f1db313a7121e735-1