chore: Stdlib curves audit#21177
Merged
federicobarbacovi merged 4 commits intoMar 11, 2026
Merged
Conversation
| using Element = Group; | ||
|
|
||
| // Additional types with no analog in the native description of the curve | ||
| using witness_ct = witness_t<CircuitBuilder>; |
Contributor
Author
There was a problem hiding this comment.
I removed these aliases because it didn't look like they belonged here
| using byte_array_ct = byte_array<Builder>; | ||
| using bool_ct = bool_t<Builder>; | ||
|
|
||
| using fq_ct = bigfield<Builder, typename ::bb::secp256k1::FqParams>; |
Contributor
Author
There was a problem hiding this comment.
Using ScalarField/BaseField/Group in the codebase. These aliases were duplicate
| using byte_array_ct = byte_array<CircuitBuilder>; | ||
| using bool_ct = bool_t<CircuitBuilder>; | ||
|
|
||
| using bigfr_ct = bigfield<CircuitBuilder, bb::Bn254FrParams>; |
Contributor
Author
There was a problem hiding this comment.
Removed as it was confusing to have a bigfield representation of the scalar field. I modified the test for biggroup so that the case in which the scalar field is instantiated via biggroup is still tested
suyash67
approved these changes
Mar 6, 2026
suyash67
left a comment
suyash67
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the cleanup!
federicobarbacovi
force-pushed
the
fb/stdlib_curve_audit
branch
from
5b2f9de to
b30e986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 Audit Context
Stdlib curve audit
🛠️ Changes Made
Only refactoring: remove some unused aliases in the structs.
✅ Checklist
📌 Notes for Reviewers