Skip to content

feat: asserts that aztec dep version matches cli#21245

Merged
AztecBot merged 1 commit into
merge-train/fairiesfrom
03-09-feat_asserts_that_aztec_dep_version_matches_cli
Mar 27, 2026
Merged

feat: asserts that aztec dep version matches cli#21245
AztecBot merged 1 commit into
merge-train/fairiesfrom
03-09-feat_asserts_that_aztec_dep_version_matches_cli

Conversation

@benesjan

@benesjan benesjan commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR I add a check that makes aztec compile throw an error in case the compile crate or any of its dependencies do not match the version of the aztec command. We are currently just checking for version equality instead of doing a more sophisticated semver checks as we are not tracking the versions reliably now. Proper semver checks are likely to be introduced in the future when we track Aztec.nr versioning separately from aztec-packages.

Since I need to check versions not only of local path based dependencies but also of the remote git based deps the approach I use here is that I check if the dep is in the relevant nargo dir, if not I fetch it there, and then I perform the check on that dep there. This means that I re-implement some nargo functionality here.

Closes https://linear.app/aztec-labs/issue/F-288/make-aztec-compile-warn-of-oldincompatible-aztec-deps-from-nargotoml

@benesjan Graphite App

benesjan commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch 2 times, most recently from 4561662 to 737db93 Compare March 10, 2026 06:37
@benesjan benesjan changed the base branch from merge-train/fairies to graphite-base/21245 March 10, 2026 06:38
@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch from 737db93 to 6267549 Compare March 10, 2026 06:38
@benesjan benesjan changed the base branch from graphite-base/21245 to jan/fix-needs-recompile-workspaces March 10, 2026 06:38
@benesjan benesjan mentioned this pull request Mar 10, 2026
Merged
@benesjan benesjan force-pushed the jan/fix-needs-recompile-workspaces branch from 1ecd98d to e79fc61 Compare March 11, 2026 02:49
@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch from 19a2794 to 1a773d5 Compare March 11, 2026 02:49
Base automatically changed from jan/fix-needs-recompile-workspaces to merge-train/fairies March 11, 2026 13:15
@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch 2 times, most recently from a42ad1e to ba392ee Compare March 24, 2026 02:19
benesjan
benesjan commented Mar 24, 2026
View reviewed changes
Comment thread docs/docs-developers/docs/aztec-nr/framework-description/dependencies.md
benesjan
benesjan commented Mar 24, 2026
View reviewed changes
Comment thread yarn-project/aztec/src/cli/cmds/utils/collect_crate_dirs.ts Outdated
benesjan
benesjan commented Mar 24, 2026
View reviewed changes
Comment thread yarn-project/aztec/src/cli/cmds/utils/collect_crate_dirs.ts Outdated
@benesjan benesjan marked this pull request as ready for review March 24, 2026 03:34
@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch 2 times, most recently from 64eaa01 to 3b7ae38 Compare March 24, 2026 07:38
@benesjan benesjan requested a review from nchamo March 24, 2026 08:13
nchamo
nchamo reviewed Mar 24, 2026
View reviewed changes

@nchamo nchamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help our users quite a bit

Comment thread yarn-project/aztec/src/cli/cmds/utils/assert_aztec_version_matches.ts Outdated
Comment thread docs/docs-developers/docs/aztec-nr/framework-description/dependencies.md Outdated
Comment thread yarn-project/aztec/src/cli/cmds/utils/warn_if_aztec_version_mismatch.ts
Comment thread yarn-project/aztec/src/cli/cmds/utils/collect_crate_dirs.ts Outdated
Comment thread yarn-project/aztec/src/cli/cmds/utils/assert_aztec_version_matches.ts Outdated
Comment thread yarn-project/aztec/src/cli/cmds/utils/assert_aztec_version_matches.ts Outdated
Comment thread yarn-project/aztec/src/cli/cmds/utils/collect_crate_dirs.ts Outdated
Comment thread docs/docs-developers/docs/aztec-nr/framework-description/dependencies.md
Comment thread yarn-project/aztec/src/cli/cmds/utils/collect_crate_dirs.test.ts Outdated
Comment thread yarn-project/aztec/src/cli/cmds/utils/collect_crate_dirs.test.ts Outdated
Base automatically changed from merge-train/fairies to next March 26, 2026 04:08
@benesjan benesjan marked this pull request as draft March 26, 2026 14:02
@benesjan benesjan changed the base branch from next to graphite-base/21245 March 26, 2026 14:19
@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch from a08f5e1 to 4351d7e Compare March 26, 2026 14:19
@benesjan benesjan changed the base branch from graphite-base/21245 to merge-train/fairies March 26, 2026 14:19
@benesjan benesjan marked this pull request as ready for review March 26, 2026 15:12
@benesjan benesjan requested a review from nchamo March 26, 2026 15:13
nchamo
nchamo approved these changes Mar 26, 2026
View reviewed changes

@nchamo nchamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Jan!

Base automatically changed from merge-train/fairies to next March 26, 2026 17:56
@benesjan benesjan added this pull request to the merge queue Mar 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@benesjan benesjan force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch from 85e075b to 1c83c24 Compare March 27, 2026 02:31
@benesjan benesjan requested a review from charlielye as a code owner March 27, 2026 02:31
@benesjan benesjan changed the base branch from next to merge-train/fairies March 27, 2026 02:31
@AztecBot AztecBot force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch from 1c83c24 to a4c7a1a Compare March 27, 2026 02:49
@AztecBot AztecBot enabled auto-merge March 27, 2026 02:49
@benesjan
feat: asserts that aztec dep version matches cli
49c0f44 
In this PR I add a check that makes `aztec compile` throw an error in case the compile crate or any of its dependencies do not match the version of the `aztec` command. We are currently just checking for version equality instead of doing a more sophisticated semver checks as we are not tracking the versions reliably now. Proper semver checks are likely to be introduced in the future when we track `Aztec.nr` versioning separately from `aztec-packages`.

Since I need to check versions not only of local path based dependencies but also of the remote git based deps the approach I use here is that I check if the dep is in the relevant nargo dir, if not I fetch it there, and then I perform the check on that dep there. This means that I re-implement some `nargo` functionality here.

Closes https://linear.app/aztec-labs/issue/F-288/make-aztec-compile-warn-of-oldincompatible-aztec-deps-from-nargotoml
@AztecBot AztecBot force-pushed the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch from a4c7a1a to 49c0f44 Compare March 27, 2026 02:51
@AztecBot AztecBot merged commit 9ef977d into merge-train/fairies Mar 27, 2026
10 checks passed
@AztecBot AztecBot deleted the 03-09-feat_asserts_that_aztec_dep_version_matches_cli branch March 27, 2026 02:52
@AztecBot AztecBot mentioned this pull request Mar 27, 2026
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Mar 27, 2026
@AztecBot
feat: merge-train/fairies (#22074)
e2c4d83 
BEGIN_COMMIT_OVERRIDE
feat(aztec-up): default install version to latest instead of nightly
(#21883)
fix(aztec-up): always reinstall noirup and foundryup bootstrappers
(#21826)
fix(aztec-up): show installed version after install (#21822)
feat(aztec-up): decouple infra assets from toolchain VERSION (#22078)
feat(aztec-up): add versioned aliases for multi-major version support
(#21817)
feat(aztec-up): auto-update before install with staleness check (#21866)
fix(aztec-up): pass VERSION to per-version installer and fix release sed
(#22083)
feat: asserts that aztec dep version matches cli (#21245)
END_COMMIT_OVERRIDE
benesjan pushed a commit that referenced this pull request Apr 16, 2026
@AztecBot @benesjan
feat: asserts that aztec dep version matches cli (#21245)
7494f11 
In this PR I add a check that makes `aztec compile` throw an error in
case the compile crate or any of its dependencies do not match the
version of the `aztec` command. We are currently just checking for
version equality instead of doing a more sophisticated semver checks as
we are not tracking the versions reliably now. Proper semver checks are
likely to be introduced in the future when we track `Aztec.nr`
versioning separately from `aztec-packages`.

Since I need to check versions not only of local path based dependencies
but also of the remote git based deps the approach I use here is that I
check if the dep is in the relevant nargo dir, if not I fetch it there,
and then I perform the check on that dep there. This means that I
re-implement some `nargo` functionality here.

Closes
https://linear.app/aztec-labs/issue/F-288/make-aztec-compile-warn-of-oldincompatible-aztec-deps-from-nargotoml
@benesjan benesjan mentioned this pull request Apr 16, 2026
Merged
benesjan added a commit that referenced this pull request Apr 16, 2026
@benesjan
chore: backport aztec CLI improvements to v4-next (#22587)
a327ba7 
## Summary

Backports 6 PRs with aztec CLI improvements from `next` to `v4-next`:

- #20681 - refactor: aztec new and init creating 2 crates
- #20711 - test: aztec new scaffold works
- #20723 - feat(cli): warning if contract crate has tests
- #20729 - feat(cli): auto-recompiling when aztec test is run
- #21007 - feat: aztec new supporting multiple contract crates
- #21245 - feat: asserts that aztec dep version matches cli
@benesjan

benesjan commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Backported to v4-next in #22587

@AztecBot AztecBot mentioned this pull request Apr 16, 2026
Merged
Thunkar added a commit that referenced this pull request Apr 17, 2026
@Thunkar
chore: Accumulated backports to v4-next (#22580)
b1aab5e 
BEGIN_COMMIT_OVERRIDE
fix(pxe): cap event filter toBlock to last synced block (#22573)
fix(pxe): round tx expiration timestamp to reduce precision (#22577)
fix: eliminate anvil watcher warp race and false success logs (#22584)
refactor: aztec new and init creating 2 crates (#20681)
test: aztec new scaffold works (#20711)
feat(cli): warning if contract crate has tests (#20723)
feat(cli): auto-recompiling when aztec test is run (#20729)
feat: aztec new supporting multiple contract crates (#21007)
feat: asserts that aztec dep version matches cli (#21245)
chore: backport aztec CLI improvements to v4-next (#22587)
feat: check noir release has nargo binaries before releasing (#22551)
chore: cache chainInfo in embeddedwallet (#22592)
fix: wrap external getCapsule in transactionAsync (#22595)
fix(pxe): throw clear error for invalid comparator in pick_notes
(#22585)
refactor(aztec-nr): rename conversion fns to encode_/decode_ naming
(#22576)
feat: infrastructure for testing `[new_contract_artfiacts,
old_aztec_stack]` (#22593)
chore: fix unnecessary and inconsistent side-effect counter increments
(#22245)
fix: update FaceID wallet redirects and strip anchors in redirect
validation (#22505)
docs: add getting started on testnet guide (#22366)
docs: add getting started on testnet guide (backport #22366) (#22619)
feat(aztec-nr): new BoundedVec emit private log APIs (#22064)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nchamo nchamo nchamo approved these changes

@charlielye charlielye Awaiting requested review from charlielye

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benesjan @nchamo @AztecBot