Skip to content

fix: silently drop invalid private messages instead of crashing PXE sync#21273

Closed
nchamo wants to merge 3 commits into
merge-train/fairiesfrom
feat/invalid-message-e2e
Closed

fix: silently drop invalid private messages instead of crashing PXE sync#21273
nchamo wants to merge 3 commits into
merge-train/fairiesfrom
feat/invalid-message-e2e

Conversation

@nchamo

@nchamo nchamo commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary

We need to be careful when handling messages and, in this particular task, we looked into event and note messages. Contracts can create invalid messages that don't have a matching note/event, so we need to make sure we can handle them gracefully. Notes already apply a filter with nonce_discovery, but events don't. We were able to build an E2E test to trigger a scenario for events that crashed PXE's sync

Now, on both the notes and event service, we will gracefully handle an invalid notes instead of throwing an error

Fixes F-343
Fixes F-361

@nchamo nchamo self-assigned this Mar 9, 2026
@nchamo nchamo requested review from benesjan and nventuro March 9, 2026 20:47
@benesjan

benesjan commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Sir, I already have PR for this open here and you reviewed it last week 😆

I am just waiting there for Nico's review here.

Weird that the issue there didn't get linked given that it's in the PR description. I guess it explicitly needs to mention "Fixes" or "Closes".

I also didn't assign myself the issue there as it was only tackling the TS side.

This is really a bad coincidence.

Will be more careful with that next time.

Given that my PR there already went through the first round of review and I have there some other useful code but you also added a test here which seems valuable I propose that:

  1. I will annoying Nico more to finally respond me there,
  2. we merge that PR of mine,
  3. you'll fix the conflicts here,
  4. we merge this as it has the nice InvalidMessage test.

Sounds good?

@nchamo

nchamo commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Lol haha, my bad. My context is cleared on weekends 😅

Sounds good 👍

@nchamo nchamo marked this pull request as draft March 10, 2026 19:01
@nchamo nchamo removed the request for review from nventuro March 10, 2026 19:01
@nventuro nventuro closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants