refactor!: cleaning up public call and tx phase related oracles (#21209) [v4 backport]#21317
Closed
AztecBot wants to merge 1 commit into
Closed
refactor!: cleaning up public call and tx phase related oracles (#21209) [v4 backport]#21317AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Backport of #21209 to v4. Replaces `enqueue_public_function_call` module with `public_call` (calldata validation) and `tx_phase` (revertible phase tracking). Renames oracle functions for clarity: - notifyEnqueuedPublicFunctionCall/notifySetPublicTeardownFunctionCall → validatePublicCalldata - notifySetMinRevertibleSideEffectCounter → notifyRevertiblePhaseStart - isSideEffectCounterRevertible → inRevertiblePhase
AztecBot
force-pushed
the
claudebox/backport-21209-to-v4
branch
from
92125ba to
eca6316
Compare
Contributor
|
Closing this because Nico's other PR with modified oracle prefixes was not backported yet due to an issue with oracle version checks. Will backport this again once that's resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21209 to
v4.enqueue_public_function_callmodule with two focused modules:public_call(calldata validation) andtx_phase(revertible phase tracking)validate_public_calldata: the old enqueue/teardown oracles both did the same thing (validate calldata) but received unused parametersnotifySetMinRevertibleSideEffectCounter→notifyRevertiblePhaseStart,isSideEffectCounterRevertible→inRevertiblePhaseORACLE_VERSIONfrom 12 to 13Adapted to v4's
privateoracle name prefix convention (vsaztec_prv_on next).