fix: search for all note nonces instead of just the one for the note index (backport #21438)#21440
Merged
nventuro merged 2 commits intoMar 12, 2026
Conversation
…index (#21438) We now search in all indices instead of just the one for the corresponding note hash.
nventuro
approved these changes
Mar 12, 2026
ludamad
pushed a commit
that referenced
this pull request
Mar 12, 2026
…index (backport #21438) (#21440) ## Summary Backport of #21438 to `v4-next`. Cherry-pick applied cleanly with no conflicts. ## Changes - Search all possible note hash indices for nonces instead of just the one corresponding to the note hash index - Add `bvec_filter` helper for filtering `BoundedVec` - Add tests for misaligned nonces, out-of-bounds indices, and duplicate unique note hashes ClaudeBox log: https://claudebox.work/s/f0603f16b3f1c566?run=1 --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21438 to
v4-next.Cherry-pick applied cleanly with no conflicts.
Changes
bvec_filterhelper for filteringBoundedVecClaudeBox log: https://claudebox.work/s/f0603f16b3f1c566?run=1