Skip to content

feat: add optional additional scopes to wallet transaction API (backport #20487)#21549

Merged
nchamo merged 9 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-20487-wallet-scopes-v4-next
Mar 13, 2026
Merged

feat: add optional additional scopes to wallet transaction API (backport #20487)#21549
nchamo merged 9 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-20487-wallet-scopes-v4-next

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

Backport of #20487 to v4-next.

Adds an explicit additionalScopes option on send(), simulate(), and deploy() so callers can declare upfront which additional addresses' private state they need access to beyond the sender's. Removes auto-expansion of scopes for nested private calls to registered account contracts.

Conflicts resolved

The main conflicts were between v4-next's destructured return types (from the offchain output changes where send() returns { txHash, ... } / { receipt, ... } / { contract, ... }) and the original PR's additionalScopes additions. Resolution: kept v4-next's destructured forms while incorporating additionalScopes parameters.

Also removed a duplicate scopesFrom method in base_wallet.ts since v4-next already had it.

Test plan

  • CI passes on v4-next
  • Verify additionalScopes is available on send/simulate/deploy options
  • Verify escrow/crowdfunding/account deploy tests compile with both destructured returns and additionalScopes

ClaudeBox log: https://claudebox.work/s/fff8a9728750d830?run=1

aminsammara and others added 7 commits March 13, 2026 11:45
## Summary
- Lower `SLASH_INACTIVITY_TARGET_PERCENTAGE` from 0.8 to 0.7
- Disable `SLASH_DUPLICATE_PROPOSAL_PENALTY` and
`SLASH_DUPLICATE_ATTESTATION_PENALTY` (set to 0)
- Increase `SLASH_GRACE_PERIOD_L2_SLOTS` from 1200 to 8400
- Reduce `perBlockAllocationMultiplier` from 2 to 1.2

## Test plan
- Verify generated config files are updated after running `yarn
generate` in relevant packages
- Deploy to devnet/testnet and confirm slasher behavior matches new
parameters

---------

Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
This PR was created because merging `v4` into `v4-next` resulted in
conflicts.

Please resolve the conflicts and merge this PR to keep `v4-next` up to
date.

This PR was auto-generated by the `pull-v4-into-v4-next` workflow.
Resolved conflicts between v4-next's destructured return types (from offchain output changes)
and the additionalScopes additions. Kept v4-next's destructured forms while adding
additionalScopes parameters from the original PR.
The cherry-pick introduced a duplicate scopesFrom method since v4-next already had it.
@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 13, 2026
@nchamo nchamo self-assigned this Mar 13, 2026
…o claudebox/backport-20487-wallet-scopes-v4-next

# Conflicts:
#	yarn-project/pxe/src/contract_function_simulator/oracle/private_execution_oracle.ts
@nchamo nchamo marked this pull request as ready for review March 13, 2026 18:44
@nchamo nchamo enabled auto-merge (squash) March 13, 2026 19:03
@nchamo nchamo merged commit bdaa5f0 into backport-to-v4-next-staging Mar 13, 2026
13 checks passed
@nchamo nchamo deleted the claudebox/backport-20487-wallet-scopes-v4-next branch March 13, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants